Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown while opening WSC dialog #33

Closed
Tade0 opened this issue Nov 19, 2015 · 9 comments
Closed

Error thrown while opening WSC dialog #33

Tade0 opened this issue Nov 19, 2015 · 9 comments
Labels

Comments

@Tade0
Copy link

Tade0 commented Nov 19, 2015

Bug in CKEditor: http://dev.ckeditor.com/ticket/13947

Steps to reproduce

  1. Open CKEditor (hash: b34ea4de6106ce5513da723ba42c3ba52da7424a) with WSC plugin (hash: d25e336)
  2. Click "Check spelling".

Expected result

Dialog is created, no errors.

Actual result

Sometimes there's an Object doesn't support property or method 'isVisible' error thrown in the console.

Error is thrown in this line:
https://github.com/ckeditor/ckeditor-dev/blob/d277ad1230d5e269a309ece0723eebcd5efd8282/plugins/dialogui/plugin.js#L934

Other details (browser, OS, CKEditor version, installed plugins)

IE11, Win 8.1, CKEditor 4.5.5

@WebSpellChecker
Copy link
Collaborator

Can't reproduce. Could you please describe more clear steps.

@AAbakumov
Copy link
Member

@Tade0 any updates on this?

@f1ames
Copy link
Contributor

f1ames commented Apr 20, 2017

I think I am able to provide more specific steps to reproduce the issue:

  1. Open the editor with WSC plugin.
  2. Set content to <p>an instance of ...</p>.
  3. Open WSC dialog and go to Thesaurus tab.
  4. Replace instance with some other word.
  5. Close dialog by clicking Finish Checking.
  6. Open WSC dialog.

Error is thrown:
image

Tested with CKEditor ckeditor/ckeditor4@2e815d0 and WSC 4.8.7.0.

@AAbakumov
Copy link
Member

AAbakumov commented Apr 21, 2017

Dear @f1ames ,

We tried to reproduce the issue with your steps but without any success.
We would like to find out the root cause of this issue. That's why we need your help:

  1. Could you please specify if there are any other editors on the page except CKEditor?
  2. Could you please provide the html code of the page or give us an access to the test environment where this issue can be reproduced?

Thank you and sorry for any inconveniences.

We are looking forward to your reply.
Regards,
The WebSpellChecker QA Team

@f1ames
Copy link
Contributor

f1ames commented Apr 21, 2017

Thank you for validating the issue, the exact steps on my side to reproduce the issue:

  1. Clone the latest ckeditor-dev/major (ckeditor/ckeditor4@191a21f).
  2. Go to ./ckeditor-dev/plugins/ and clone WSC there (edc4af5) as ./wsc.
  3. Open ./ckeditor-dev/config.js and add wsc to config.plugins so the plugin will be included.
  4. Open ./ckeditor-dev/samples/index.html in a browser (I used Chrome 57.0.2987.133 (64-bit) on OSX).
  5. Switch to Source mode in CKEditor.
  6. Replace whole content with <p>an instance of ...</p>.
  7. Switch back to WYSIWYG mode.
  8. Open WSC dialog and go to Thesaurus tab.
  9. Replace instance with ideal (using Change to button).
  10. Close dialog by clicking Finish Checking.
  11. Open WSC dialog.

After the 11th step, error mentioned in my previous comment is thrown.

@AAbakumov
Copy link
Member

Dear @f1ames ,

Thank you so much for such detailed steps. We were able to reproduce the issue. The problem comes out when we use the Source mode in the CKEditor.

I have created a task for our Dev Team and notified them.

Thank you so much for your help!
Sincerely,
The WebSpellChecker QA Team

@f1ames
Copy link
Contributor

f1ames commented Apr 24, 2017

@wsc-bug-hunter, I am glad it was helpful and made possible to reproduce the issue. If any more information is needed I am here to help.
Waiting for the update on the issue.

@AAbakumov
Copy link
Member

Dear @f1ames,
We are glad to inform you that issue with the console error has been fixed and will be released in the middle of May with the product version 4.8.9.

Thank you so much for your patience and your help.

Sincerely,
The WebSpellChecker QA Team

@f1ames
Copy link
Contributor

f1ames commented Apr 27, 2017

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants