Skip to content

Commit

Permalink
Skip LE challenge verification. (#2280)
Browse files Browse the repository at this point in the history
The verification was implemented wrong and could cause the
registration process to hang for 20+ minutes. A newer,
unreleased version of acme-client has an option to skip the
verification step, so use that.
  • Loading branch information
mrstegeman committed Nov 12, 2019
1 parent c24eac2 commit fec6a9b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
7 changes: 3 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"dependencies": {
"@fluent/bundle": "^0.14.0",
"@fluent/dom": "^0.6.0",
"acme-client": "^3.2.0",
"acme-client": "https://github.com/publishlab/node-acme-client#7bb000d561cda8e31e3dc82e6f499d947dd92a0e",
"ajv": "^6.10.2",
"archiver": "^3.1.1",
"asn1.js": "^5.2.0",
Expand Down
1 change: 1 addition & 0 deletions src/certificate-manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ async function register(email, reclamationToken, subdomain, fulldomain,
csr,
email: config.get('ssltunnel.certemail'),
termsOfServiceAgreed: true,
skipChallengeVerification: true,
challengePriority: ['dns-01'],
challengeCreateFn,
challengeRemoveFn,
Expand Down

0 comments on commit fec6a9b

Please sign in to comment.