-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Device Timeout #37
Comments
We didn't get around to implementing this in 0.2, it would be good to get it into 0.3 so the spinner doesn't just spin forever! |
Should be easy enough to add, but what timeout? 30s? |
@dhylands Do you know how long it takes for Zigbee and Z-Wave adapters to time out? If we could surface the timeout to the UI through the WebSocket API rather than use a fixed timeout that would be a better solution because otherwise things could get paired added after the timeout. |
The problem is that each adapter can have a completely different timeout. For instance, the TP-Link adapter is pinned at 3 seconds, because that's all it really takes. |
Zwave has no timeout. With Zigbee the timeout can be anything between 1 and 254 seconds. It's currently set to 180 seconds in the config. |
How about if we set the Zigbee timeout to say 60 seconds (or 120 seconds?) and turn of Z-Wave pairing after that same period of time? |
Seems reasonable to me. |
Currently the Add New Device dialog will appear to keep scanning for new devices forever.
We should add a timeout (at the adapter layer, the UI layer, or both) and close open websockets when we're done.
The text was updated successfully, but these errors were encountered: