Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Device Timeout #37

Closed
benfrancis opened this issue Apr 19, 2017 · 7 comments
Closed

Add New Device Timeout #37

benfrancis opened this issue Apr 19, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@benfrancis
Copy link
Member

Currently the Add New Device dialog will appear to keep scanning for new devices forever.

We should add a timeout (at the adapter layer, the UI layer, or both) and close open websockets when we're done.

@benfrancis benfrancis modified the milestone: Q2 2017 May 23, 2017
@benfrancis benfrancis modified the milestones: 0.2, 0.1 Jul 10, 2017
@benfrancis benfrancis modified the milestones: 0.2, 0.3.0 Jan 26, 2018
@benfrancis
Copy link
Member Author

We didn't get around to implementing this in 0.2, it would be good to get it into 0.3 so the spinner doesn't just spin forever!

@mrstegeman
Copy link
Contributor

Should be easy enough to add, but what timeout? 30s?

@benfrancis
Copy link
Member Author

@dhylands Do you know how long it takes for Zigbee and Z-Wave adapters to time out? If we could surface the timeout to the UI through the WebSocket API rather than use a fixed timeout that would be a better solution because otherwise things could get paired added after the timeout.

@mrstegeman
Copy link
Contributor

The problem is that each adapter can have a completely different timeout. For instance, the TP-Link adapter is pinned at 3 seconds, because that's all it really takes.

@dhylands
Copy link
Contributor

Zwave has no timeout. With Zigbee the timeout can be anything between 1 and 254 seconds. It's currently set to 180 seconds in the config.

@benfrancis
Copy link
Member Author

How about if we set the Zigbee timeout to say 60 seconds (or 120 seconds?) and turn of Z-Wave pairing after that same period of time?

@mrstegeman
Copy link
Contributor

Seems reasonable to me.

mrstegeman pushed a commit to mrstegeman/gateway that referenced this issue Feb 5, 2018
@ghost ghost assigned mrstegeman Feb 5, 2018
@ghost ghost added review and removed next labels Feb 5, 2018
hobinjk pushed a commit that referenced this issue Feb 6, 2018
@ghost ghost removed the review label Feb 6, 2018
hobinjk pushed a commit to hobinjk/gateway that referenced this issue Feb 6, 2018
hobinjk pushed a commit that referenced this issue Feb 6, 2018
@mrstegeman mrstegeman added this to Done in WebThings Gateway Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants