Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands API when using local HTTP. #740

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

mrstegeman
Copy link
Contributor

Fixes #617

@ghost ghost assigned mrstegeman Mar 6, 2018
@ghost ghost added the review label Mar 6, 2018
@codecov-io
Copy link

codecov-io commented Mar 6, 2018

Codecov Report

Merging #740 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #740      +/-   ##
=========================================
- Coverage   78.93%   78.9%   -0.03%     
=========================================
  Files          84      84              
  Lines        3408    3409       +1     
  Branches      448     448              
=========================================
  Hits         2690    2690              
- Misses        660     661       +1     
  Partials       58      58
Impacted Files Coverage Δ
src/app.js 66.43% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eae5d5...0f56b11. Read the comment docs.

Copy link
Contributor

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mrstegeman mrstegeman merged commit 10a643a into WebThingsIO:master Mar 6, 2018
@mrstegeman mrstegeman deleted the fix-commands-controller branch March 6, 2018 21:57
@ghost ghost removed the review label Mar 6, 2018
@mrstegeman mrstegeman added this to Done in WebThings Gateway Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants