example: Rename brightness property to level #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align properties to Virtual Dimmable Light from VirtualThings adapter (same as arduino too) This change was motivated by aframe-webthing project that could use either this example or gateway. Relate-to: rzr/aframe-webthing@60ea9f8 Change-Id: I22197c6b78c7e6f56f9485c4c028aa62a16d12f9 Signed-off-by: Philippe Coval <p.coval@samsung.com>
|
It was renamed to |
|
Ok then adapter and arduino code maybe updated too (if it is'nt done already, I didn't check yet). seems not function brightness() {
return {
name: 'level',@ https://github.com/mozilla-iot/virtual-things-adapter/blob/master/virtual-things-adapter.js#L126 https://github.com/mozilla-iot/webthing-arduino/blob/master/examples/RGBLamp/RGBLamp.ino#L38 So please confirm both should be patched too align |
rzr
added a commit
to TizenTeam/webthing-esp8266
that referenced
this pull request
Jul 11, 2019
Aligned to Spec: https://iot.mozilla.org/wot/#example-2-a-more-complex-thing-description-with-semantic-annotations Fixed minor build issues too. Change-Id: I43b9fbc609a226ecb00729c32847670b8f91a5da Relate-to: WebThingsIO/webthing-node#108 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to TizenTeam/virtual-things-adapter
that referenced
this pull request
Jul 14, 2019
Change-Id: I09b81c0aaa6d5e26b6a6c30f731a5646217e5e67 Relate-to: WebThingsIO/webthing-node#108 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to TizenTeam/virtual-things-adapter
that referenced
this pull request
Jul 14, 2019
According to: https://iot.mozilla.org/wot/#example-2-a-more-complex-thing-description-with-semantic-annotations For some reason, "brightness" name is preferred over "level" one. Change-Id: I09b81c0aaa6d5e26b6a6c30f731a5646217e5e67 Relate-to: WebThingsIO/webthing-node#108 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to TizenTeam/virtual-things-adapter
that referenced
this pull request
Jul 14, 2019
According to: https://iot.mozilla.org/wot/#example-2-a-more-complex-thing-description-with-semantic-annotations For some reason, "brightness" name is preferred over "level" one. Change-Id: I09b81c0aaa6d5e26b6a6c30f731a5646217e5e67 Forwarded: WebThingsIO#35 Relate-to: WebThingsIO/webthing-node#108 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align properties to Virtual Dimmable Light
from VirtualThings adapter (same as arduino too)
This change was motivated by aframe-webthing project
that could use either this example or gateway.
Relate-to: rzr/aframe-webthing@60ea9f8
Change-Id: I22197c6b78c7e6f56f9485c4c028aa62a16d12f9
Signed-off-by: Philippe Coval p.coval@samsung.com