Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parameters for BENEVE VR5 headset with integrated display #30

Merged
merged 2 commits into from Jan 19, 2018

Conversation

devasur
Copy link
Contributor

@devasur devasur commented Dec 7, 2017

BENEVE VR5 is a headset with an integrated display. Got requirement from a customer to support this VR headset. Have tested the accuracy on the headset using a test program here : https://devasur.github.io/vrtest/basic/ (updated the local dbdb.json withing polyfill).

Request adding to the database.

@jsantell
Copy link
Contributor

jsantell commented Dec 7, 2017

Thanks for this! This is failing some tests we have for the mdmh value (check out format of others), and for having a resolution on an Android device parameter which is usually unnecessary and only used for iOS devices, but could still be useful in this case -- for example, are there devices that would match the provided UA string but have a different resolution? Otherwise, it may be safer to just remove that. If it's necessary, I can relax the testing rules as new devices may break previous assumptions about data.

Thanks!

@devasur
Copy link
Contributor Author

devasur commented Dec 8, 2017

Thanks for reviewing. I have made corrections. Removed the res rules also.

@thoragio thoragio merged commit c84c149 into immersive-web:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants