New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add autoprettier
github action
#223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretittier really confilcts with eslint and eslint with a code style configurations works better than prettier and also tells the errors and warnings instead of just saying that "you forgot to run prettier"
Therefore I do not recommend prettier
This is for Hacktoberfest. The GitHub action is much simpler to manage PR as it auto format files. I have a full time work so I can be late in reviewing the suggestions. And spending day suggesting changes for quotes and double quotes isn't fun at all, even for the contributors. We can improve, maybe after Hacktoberfest, more optimization requirements. Or just open a new issue to mention the eslint performance suggestion? That can even be a new hacktoberfest issue. Optimization is a good topic to collaborate with content and metrics. Not to mention, that 2 days ago, you were ok for it! (Prettier)
CC @WebXDAO/core-maintainer |
Not to mention, that 2 days ago, you were #212 (comment) I do not mean to have the kind of prettier config you are talking about - just one that is going to use the ESLint config - I think prettier have plugin for that |
@krshkun Oki! What if we open a new issue for replacing the prettier thing? I think that'll be proper tasks to see how eslint replace prettier from this new issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, let's merge this but heads up Codacy is going to fail on basically on all PRs so we'll have to ignore it /cc @vinzvinci @Panquesito7 @shuklaritvik06 (Tagging the maintainers) 👍
Related Issue
Closes: #221
Describe the changes you've made
autoprettier.yaml
GitHub Action to autoformat filesNavbar
component which used vanilla router -> replaced by nextjsLink
routergrid
class which breaked thecontributor
andblog
page (there was already aflex
+flex wrap
so no need of usinggrid
here!)Type of change
What sort of change have you made:
Checklist
Screenshots (if applicable)
Code of Conduct