Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add autoprettier github action #223

Merged
merged 4 commits into from Oct 5, 2022
Merged

chore: add autoprettier github action #223

merged 4 commits into from Oct 5, 2022

Conversation

mkubdev
Copy link
Contributor

@mkubdev mkubdev commented Oct 4, 2022

Related Issue

  • Information about the related issue

Closes: #221

Describe the changes you've made

  • Setup autoprettier.yaml GitHub Action to autoformat files
  • Formated the projects
  • Added prettier.rc with double quote format config
  • Fixed the Navbar component which used vanilla router -> replaced by nextjs Link router
  • Removed multiples circles absolute div: not matching our current design
  • Removed a grid class which breaked the contributor and blog page (there was already a flex + flex wrap so no need of using grid here!)

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@mkubdev mkubdev added the enhancement New feature or request label Oct 4, 2022
Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretittier really confilcts with eslint and eslint with a code style configurations works better than prettier and also tells the errors and warnings instead of just saying that "you forgot to run prettier"

Therefore I do not recommend prettier

@gptkrsh gptkrsh added the In-Discussion This issue is in discussion label Oct 4, 2022
@mkubdev
Copy link
Contributor Author

mkubdev commented Oct 4, 2022

This is for Hacktoberfest.

The GitHub action is much simpler to manage PR as it auto format files. I have a full time work so I can be late in reviewing the suggestions. And spending day suggesting changes for quotes and double quotes isn't fun at all, even for the contributors.

We can improve, maybe after Hacktoberfest, more optimization requirements. Or just open a new issue to mention the eslint performance suggestion? That can even be a new hacktoberfest issue. Optimization is a good topic to collaborate with content and metrics.

Not to mention, that 2 days ago, you were ok for it! (Prettier)

  • We can continue like this for now, more optimizations can be suggested or worked on later.

CC @WebXDAO/core-maintainer

@gptkrsh
Copy link

gptkrsh commented Oct 5, 2022

Not to mention, that 2 days ago, you were ok for it! (Prettier)

Not to mention, that 2 days ago, you were #212 (comment)

I do not mean to have the kind of prettier config you are talking about - just one that is going to use the ESLint config - I think prettier have plugin for that

@mkubdev
Copy link
Contributor Author

mkubdev commented Oct 5, 2022

@krshkun Oki! What if we open a new issue for replacing the prettier thing? I think that'll be proper tasks to see how eslint replace prettier from this new issue!

Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, let's merge this but heads up Codacy is going to fail on basically on all PRs so we'll have to ignore it /cc @vinzvinci @Panquesito7 @shuklaritvik06 (Tagging the maintainers) 👍

@mkubdev mkubdev merged commit bb36636 into WebXDAO:main Oct 5, 2022
@mkubdev mkubdev added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed In-Discussion This issue is in discussion hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add prettier github action
3 participants