-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
…P 7 and to test lowest and latest dependencies
… special configuration
@juriansluiman Would you please consider merging this? Could need that in a project. |
Hello, I tested your branch in my zf3 project. I think you should change one more thing. When I run the code I get the following error:
This is because you put this code inside the factory method called by zf3:
I already had a module with support for both zf2 and zf3 and I know that zf2 uses the createService() method while zf3 uses the __invoke method, so you don't need to check if the method exists because is deprecated, simply remove those lines fix the problem. I hope I explained the problem, thank you |
Since deprecated is not a serious error, this is exactly as expected. To make this work with ZF2 and ZF3, this call is necessary. |
I don't understand why you say that the call is necessary, since zf2 call the createService() service while zf3 calls the __invoke() method. Can you explain me please? Thank you |
As of ZF3, `ServiceManager::getServiceLocator` is marked as deprecated. Since we only need that in ZF2, I moved the logic to `ZF2` only logic.
Didn't got you right. Actually I thought you wanted to remove the call at all. |
Thank you |
I'm sorry to bother you again, but you should fix the same thing in BeanstalkdWorkerControllerFactory, thank you. |
I guess that this repository might be dead. @juriansluiman If you want me to take over this repository, please give me a note so I can maintain this as long as I have time. |
I'm also available to maintain the repository |
Added support for ZF3 but had to drop PHP 5.3 and PHP 5.4 support.
In addition I've added PHP 7 and PHP 7.1.