Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing block selector #456

Closed
Pavel910 opened this issue Feb 5, 2019 · 1 comment
Closed

Missing block selector #456

Pavel910 opened this issue Feb 5, 2019 · 1 comment
Assignees
@SvenAlHamad

Comments

@Pavel910
Copy link
Collaborator

Pavel910 commented Feb 5, 2019

When hovering on a block element, block selector element is not visible.

image
@Pavel910
Copy link
Collaborator Author

Pavel910 commented Feb 6, 2019

After an element preview is generated, type element is no longer visible.
This has something to do with not restoring display css property, at this location:
packages/webiny-app-cms/src/editor/plugins/elementSettings/save/SaveDialog/ElementPreview.js:64

Since the display value changes depending on situation, we can not just hardcode block there.
Leaving this for better times, as this is not a critical bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SvenAlHamad SvenAlHamad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SvenAlHamad @Pavel910