Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Attachment name decoding #421

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

nuernbergerA
Copy link
Contributor

Added a failing test for attachment filename decoding issue.

As always its related to umlauts.


#410

@Webklex
Copy link
Owner

Webklex commented Jun 27, 2023

Hi @nuernbergerA ,
many thanks for your pr! The failed test message is indeed strange:

There was 1 failure:

1) Tests\issues\Issue410Test::testIssueEmailB
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'2021_Mängelliste_0819306.xlsx'
+'2021_Mängelliste_0819306.xlsx'

/home/runner/work/php-imap/php-imap/tests/issues/Issue410Test.php:47

I currently can't make sense of it - I'll have to play around with it and think about it :)

Best regards & thanks again,

@nuernbergerA
Copy link
Contributor Author

nuernbergerA commented Jun 27, 2023

Hey @Webklex

the output from github actions is normalized
expected is an "ä"
actual is "a"+" ̈"

see https://unicode.org/charts/nameslist/n_0300.html (COMBINING DIAERESIS)

@Webklex
Copy link
Owner

Webklex commented Jun 28, 2023

Hi @nuernbergerA ,
many thanks for the followup. It's the first time I came across the topic of COMBINING DIAERESIS - always something new. I believe I found the culprit, but lets see my next commit fixes it or not :)

Thanks again,

@Webklex Webklex merged commit 57e7d28 into Webklex:master Jun 28, 2023
0 of 3 checks passed
Webklex added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants