fix(component): ignore non-existing push branch when checking pending

It can be non-existing yet (after initial setup) or removed after merging a pull request. Fixes #11613 Fixes WEBLATE-7NT Fixes WEBLATE-7KT
WeblateOrg · May 13, 2024 · 66151d4 · 66151d4
1 parent 43e5c77
commit 66151d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/docs/changes.rst b/docs/changes.rst
@@ -9,6 +9,8 @@ Not yet released.
 
 **Bug fixes**
 
+* False-positive merge failure alert when using push branch.
+
 **Compatibility**
 
 **Upgrading**

diff --git a/weblate/trans/models/component.py b/weblate/trans/models/component.py
@@ -3245,9 +3245,8 @@ def count_push_branch_outgoing(self):
             return 0
         try:
             return self.repository.count_outgoing(self.push_branch)
-        except RepositoryError as error:
-            report_error(cause="Could check merge needed", project=self.project)
-            self.add_alert("MergeFailure", error=self.error_text(error))
+        except RepositoryError:
+            # We silently ignore this error as push branch might not be existing if not needed
             return 0
 
     def needs_commit(self):