feat(notification): turn on digest notification on new strings by def…

…ault

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes #10533

weblate/accounts/data.py

@@ -4,6 +4,7 @@
 
 from weblate.accounts.notifications import (
     FREQ_INSTANT,
+    FREQ_WEEKLY,
     SCOPE_ADMIN,
     SCOPE_ALL,
     SCOPE_WATCHED,
@@ -14,6 +15,7 @@
     (SCOPE_WATCHED, FREQ_INSTANT, "LastAuthorCommentNotificaton"),
     (SCOPE_WATCHED, FREQ_INSTANT, "MentionCommentNotificaton"),
     (SCOPE_WATCHED, FREQ_INSTANT, "NewAnnouncementNotificaton"),
+    (SCOPE_WATCHED, FREQ_WEEKLY, "NewStringNotificaton"),
     (SCOPE_ADMIN, FREQ_INSTANT, "MergeFailureNotification"),
     (SCOPE_ADMIN, FREQ_INSTANT, "ParseErrorNotification"),
     (SCOPE_ADMIN, FREQ_INSTANT, "NewTranslationNotificaton"),

weblate/accounts/tests/test_notifications.py

@@ -73,6 +73,12 @@ def setUp(self) -> None:
             "LastAuthorCommentNotificaton",
         )
         for notification in notifications:
+            # Remove any conflicting notifications
+            Subscription.objects.filter(
+                user=self.user,
+                scope=SCOPE_WATCHED,
+                notification=notification,
+            ).delete()
             Subscription.objects.create(
                 user=self.user,
                 scope=SCOPE_WATCHED,
@@ -430,6 +436,7 @@ def test_reminder(
         notification="ToDoStringsNotification",
         subj="4 unfinished strings in Test/Test",
     ) -> None:
+        self.user.subscription_set.filter(frequency=frequency).delete()
         self.user.subscription_set.create(
             scope=SCOPE_WATCHED, notification=notification, frequency=frequency
         )

weblate/accounts/tests/test_views.py

@@ -436,7 +436,7 @@ def test_userdata(self) -> None:
     def test_subscription(self) -> None:
         # Get profile page
         response = self.client.get(reverse("profile"))
-        self.assertEqual(self.user.subscription_set.count(), 9)
+        self.assertEqual(self.user.subscription_set.count(), 10)
 
         # Extract current form data
         data: dict[str, str | list[str]] = {}
@@ -454,20 +454,20 @@ def test_subscription(self) -> None:
         # Save unchanged data
         response = self.client.post(reverse("profile"), data, follow=True)
         self.assertContains(response, "Your profile has been updated.")
-        self.assertEqual(self.user.subscription_set.count(), 9)
+        self.assertEqual(self.user.subscription_set.count(), 10)
 
         # Remove some subscriptions
         data["notifications__1-notify-LastAuthorCommentNotificaton"] = "0"
         data["notifications__1-notify-MentionCommentNotificaton"] = "0"
         response = self.client.post(reverse("profile"), data, follow=True)
         self.assertContains(response, "Your profile has been updated.")
-        self.assertEqual(self.user.subscription_set.count(), 7)
+        self.assertEqual(self.user.subscription_set.count(), 8)
 
         # Add some subscriptions
         data["notifications__2-notify-ChangedStringNotificaton"] = "1"
         response = self.client.post(reverse("profile"), data, follow=True)
         self.assertContains(response, "Your profile has been updated.")
-        self.assertEqual(self.user.subscription_set.count(), 8)
+        self.assertEqual(self.user.subscription_set.count(), 9)
 
     def test_subscription_customize(self) -> None:
         # Initial view
@@ -497,7 +497,7 @@ def test_subscription_customize(self) -> None:
 
     def test_watch(self) -> None:
         self.assertEqual(self.user.profile.watched.count(), 0)
-        self.assertEqual(self.user.subscription_set.count(), 9)
+        self.assertEqual(self.user.subscription_set.count(), 10)
 
         # Watch project
         self.client.post(reverse("watch", kwargs={"path": self.project.get_url_path()}))
@@ -529,11 +529,11 @@ def test_watch(self) -> None:
         self.assertEqual(
             self.user.subscription_set.filter(component=self.component).count(), 0
         )
-        self.assertEqual(self.user.subscription_set.count(), 9)
+        self.assertEqual(self.user.subscription_set.count(), 10)
 
     def test_watch_component(self) -> None:
         self.assertEqual(self.user.profile.watched.count(), 0)
-        self.assertEqual(self.user.subscription_set.count(), 9)
+        self.assertEqual(self.user.subscription_set.count(), 10)
 
         # Watch component
         self.client.post(reverse("watch", kwargs=self.kw_component))
@@ -544,7 +544,7 @@ def test_watch_component(self) -> None:
         )
         # Only default notifications should be enabled
         self.assertEqual(
-            self.user.subscription_set.filter(component=self.component).count(), 3
+            self.user.subscription_set.filter(component=self.component).count(), 4
         )
 
     def test_unsubscribe(self) -> None:

weblate/api/tests.py

@@ -253,7 +253,7 @@ def test_list_notifications(self) -> None:
             superuser=True,
             code=200,
         )
-        self.assertEqual(response.data["count"], 9)
+        self.assertEqual(response.data["count"], 10)
 
     def test_post_notifications(self) -> None:
         self.do_request(
@@ -274,7 +274,7 @@ def test_post_notifications(self) -> None:
                 "frequency": 1,
             },
         )
-        self.assertEqual(Subscription.objects.count(), 10)
+        self.assertEqual(Subscription.objects.count(), 11)
 
     def test_get_notifications(self) -> None:
         user = User.objects.filter(is_active=True)[0]
@@ -344,7 +344,7 @@ def test_delete_notifications(self) -> None:
             superuser=True,
             code=204,
         )
-        self.assertEqual(Subscription.objects.count(), 8)
+        self.assertEqual(Subscription.objects.count(), 9)
 
     def test_statistics(self) -> None:
         user = User.objects.filter(is_active=True)[0]