Added check for non writable files in DATA_DIR

This usually indicates some configuration issue, eg. celery running as
different user than wsgi. See #2400

Signed-off-by: Michal Čihař <michal@cihar.com>

docs/changes.rst

@@ -19,6 +19,7 @@ Released on October 20th 2018.
 * Added translation component alerts to highlight problems with a translation.
 * Expose XLIFF unit resname as context when available.
 * Added support for XLIFF states.
+* Added check for non writable files in DATA_DIR.
 
 weblate 3.2.1
 -------------

weblate/utils/apps.py

@@ -25,7 +25,7 @@
 from weblate.utils.checks import (
     check_mail_connection, check_celery, check_database,
     check_cache, check_settings, check_templates,
-    check_data_writable, check_site,
+    check_data_writable, check_site, check_perms,
 )
 from weblate.utils.fonts import check_fonts
 from weblate.utils.requirements import check_requirements
@@ -49,5 +49,6 @@ def ready(self):
         register(check_settings, deploy=True)
         register(check_templates, deploy=True)
         register(check_site, deploy=True)
+        register(check_perms, deploy=True)
 
         monkey_patch_translate()

weblate/utils/checks.py

@@ -20,7 +20,8 @@
 
 from __future__ import unicode_literals, absolute_import
 
-import os.path
+from itertools import chain
+import os
 
 from celery.exceptions import TimeoutError
 
@@ -273,3 +274,30 @@ def check_site(app_configs, **kwargs):
             )
         )
     return errors
+
+
+def check_perms(app_configs=None, **kwargs):
+    """Check we can write to data dir."""
+    errors = []
+    ignore = (
+        '.git', '.hg', '.svn',
+        'test-base-repo.git', 'test-base-repo.svn',
+        'test-repo.git', 'test-repo.svn',
+    )
+    message = 'Path {} is not writable, check your DATA_DIR settings.'
+    for dirpath, dirnames, filenames in os.walk(settings.DATA_DIR):
+        for name in ignore:
+            if name in dirnames:
+                dirnames.remove(name)
+        for name in chain(dirnames, filenames):
+            path = os.path.join(dirpath, name)
+            if not os.access(path, os.W_OK):
+                errors.append(
+                    Critical(
+                        message.format(path),
+                        hint=get_doc_url('admin/install', 'file-permissions'),
+                        id='weblate.E002',
+                    )
+                )
+
+    return errors