Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for perl-brace-format #10626

Closed
2 tasks done
joubu opened this issue Dec 14, 2023 · 4 comments · Fixed by #10633
Closed
2 tasks done

Missing check for perl-brace-format #10626

joubu opened this issue Dec 14, 2023 · 4 comments · Fixed by #10633
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Milestone

Comments

@joubu
Copy link
Contributor

joubu commented Dec 14, 2023

Describe the issue

I may be missing something obvious here, but I am seeing the following 2 issues (caught using junitmsgfmt on .po files):

  1. Typo in parameter
#, perl-brace-format
msgid "Delete CSV profile '{csv_profile_name}'?"
msgstr "CSV-Profil '{csv_provile_name}' löschen?"
  1. Square brackets instead of curly brackets:
#, perl-brace-format
msgid "Modify {servertype} server '{servername}'"
msgstr "Server {servertype]-Server '{servername}'"

They are not caught by Weblate's UI, is this expected? Is it related with perl-brace-format?

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Have an incorrect msgstr translations, go to the translation and expect a warning.

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@joubu
Copy link
Contributor Author

joubu commented Dec 14, 2023

Is it because Weblate expects perl-format instead of perl-brace-format?

https://docs.weblate.org/en/latest/user/checks.html#perl-format

@nijel
Copy link
Member

nijel commented Dec 14, 2023

I guess that is something different, similarly as with Python there are two ways of formatting.

@nijel nijel added enhancement Adding or requesting a new feature. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. labels Dec 14, 2023
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

joubu added a commit to joubu/weblate that referenced this issue Dec 15, 2023
perl-format and perl-brace-format are distinct
https://www.gnu.org/software/gettext/manual/html_node/perl_002dformat.html

This patch adds support for perl-brace-format:
  "There are {number} apples"
joubu added a commit to joubu/weblate that referenced this issue Dec 15, 2023
perl-format and perl-brace-format are distinct
https://www.gnu.org/software/gettext/manual/html_node/perl_002dformat.html

This patch adds support for perl-brace-format:
  "There are {number} apples"
joubu added a commit to joubu/weblate that referenced this issue Dec 15, 2023
perl-format and perl-brace-format are distinct
https://www.gnu.org/software/gettext/manual/html_node/perl_002dformat.html

This patch adds support for perl-brace-format:
  "There are {number} apples"
joubu added a commit to joubu/weblate that referenced this issue Dec 15, 2023
perl-format and perl-brace-format are distinct
https://www.gnu.org/software/gettext/manual/html_node/perl_002dformat.html

This patch adds support for perl-brace-format:
  "There are {number} apples"
joubu added a commit to joubu/weblate that referenced this issue Dec 15, 2023
perl-format and perl-brace-format are distinct
https://www.gnu.org/software/gettext/manual/html_node/perl_002dformat.html

This patch adds support for perl-brace-format:
  "There are {number} apples"
nijel pushed a commit that referenced this issue Dec 18, 2023
perl-format and perl-brace-format are distinct
https://www.gnu.org/software/gettext/manual/html_node/perl_002dformat.html

This patch adds support for perl-brace-format:
  "There are {number} apples"
nijel added a commit that referenced this issue Dec 18, 2023
@nijel nijel linked a pull request Dec 18, 2023 that will close this issue
5 tasks
@nijel nijel added this to the 5.4 milestone Dec 18, 2023
@nijel nijel closed this as completed Dec 18, 2023
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants