Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for xliff generic placeholder - <x /> #1535

Closed
ddukstas opened this issue Jun 29, 2017 · 3 comments · Fixed by #2364
Closed

Support for xliff generic placeholder - <x /> #1535

ddukstas opened this issue Jun 29, 2017 · 3 comments · Fixed by #2364
Labels
enhancement Adding or requesting a new feature.
Projects
File format support
Milestone
3.4

Comments

@ddukstas
Copy link

ddukstas commented Jun 29, 2017 •
edited by nijel

Xliff entry with variables in it looks something like this:

<trans-unit id="6644865400824058724" datatype="html">
    <source>Shot by player <x id="PLAYER"/></source>
</trans-unit>

Actual behaviour

Weblate UI does not seem to handle <x /> tags - it just omits it from source field.
example screenshot

Expected behaviour

<x /> placeholders should be displayed in translation source input field, so that translators would be aware of them. There should also be a way to enter these placeholders in translation target input field.
@nijel nijel added the enhancement Adding or requesting a new feature. label Jun 29, 2017
@nijel nijel added this to TODO in File format support Jun 29, 2017
@nijel nijel mentioned this issue Oct 24, 2018
Closed
@PowerKiKi
Copy link
Contributor

@nijel, since this is a blocker for me, I'd be willing to submit a PR for it, but I have no experience in Weblate. Could you point me in the right direction, on how to contribute in general, and what should be done in what part of code for this specific feature ?

@PowerKiKi
Copy link
Contributor

PowerKiKi commented Oct 26, 2018 •
edited

This is a duplicate of #490 (or the other way around). One of them should probably be closed.

PS: To answer my own previous question, see #490 (comment)

@nijel
Copy link
Member

nijel commented Oct 26, 2018

Good point, it indeed is (though it doesn't specifically mention placeholders).

Duplicate of #490

@nijel nijel closed this as completed Oct 26, 2018
File format support automation moved this from TODO to Done Oct 26, 2018
@PowerKiKi PowerKiKi mentioned this issue Oct 31, 2018
Merged
4 tasks
PowerKiKi added a commit to PowerKiKi/weblate that referenced this issue Nov 29, 2018
@PowerKiKi
Add support for XLIFF placeholders
12252a9 
This should allow to translate units containing placeholders such
as the one used by Angular i18n.

PoXliff will not support placehoders, because it probably doesn't
make sense to support XLIFF specific placeholders in a format that
actually embed PO placeholders.

Fixes WeblateOrg#490
Fixes WeblateOrg#1535

Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
@nijel nijel added this to the 3.4 milestone Nov 30, 2018
nijel added a commit that referenced this issue Nov 30, 2018
@nijel
Add changelog for #2364
da876ac 
Fixes #490
Fixes #1535

Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adding or requesting a new feature.
Projects
File format support
  
Done
Milestone
3.4
Development

Successfully merging a pull request may close this issue.

Add support for XLIFF placeholders PowerKiKi/weblate
3 participants
@PowerKiKi @nijel @ddukstas