Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support federated login [$5 awarded] #170

Closed
stefanb opened this issue Nov 28, 2012 · 10 comments
Closed

Support federated login [$5 awarded] #170

stefanb opened this issue Nov 28, 2012 · 10 comments
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
1.8

Comments

@stefanb
Copy link
Contributor

stefanb commented Nov 28, 2012 •
edited by nijel

Creating yet another account with a separate password can be a hurdle, turning away some potential translators.

This could be improved by supporting login with existing accounts that provide federated login:

  • Google accounts
  • Facebook accounts
  • other OAuth providers ?
  • ... any OpenID provider ?

http://en.wikipedia.org/wiki/Federated_identity
@stefanb stefanb mentioned this issue Nov 28, 2012
Closed
@nijel
Copy link
Member

nijel commented Nov 28, 2012

Indeed it would be useful, but this is not a high priority for me right now. There are currently many Django apps for that, these two look most promising:

https://github.com/omab/django-social-auth
https://github.com/pennersr/django-allauth

@stefanb
Copy link
Contributor Author

stefanb commented Nov 28, 2012

Indeed, anonymous suggestions help with this obstacle too.

@stefanb
Copy link
Contributor Author

stefanb commented Nov 28, 2012

Indeed, anonymous suggestions help with this obstacle too.

"If you would like to contribute to translation of Weblate, you need to register on this server."
on https://l10n.cihar.com/engage/weblate/
is not 100% accurate and might scare some people away.

@schuon
Copy link

schuon commented Jan 18, 2013

Wouldn't it be smart to link it with Github accounts? When using github as git hosting provider, all would be tied together :)

@stefanb
Copy link
Contributor Author

stefanb commented Jan 18, 2013

Indeed, github can also act as OAuth provider: http://developer.github.com/v3/oauth/

@nijel
Copy link
Member

nijel commented Jan 18, 2013

Github is supported by both mentioned apps.

@nijel
Copy link
Member

nijel commented Jun 5, 2013

Maybe it's time to replace django-registration with django-allauth as registration has just again changed API in a incompatible way, making it impossible to support both 0.8 and 0.9 (the same happened with 0.7 and 0.8).

http://www.intenct.nl/projects/django-allauth/

@Marlinc
Copy link

Marlinc commented Jun 25, 2013

This would be very awesome!

@ghost ghost assigned nijel Oct 8, 2013
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Initial support for social authentication
26dc726 
Right now only basic login works and is not really integrated into rest
of Weblate.

Issue #170
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Simple social auth connections management (issue #170)
8972544
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Better management of connected identities
fa2dbe7 
Issue #170
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Basic documentation for social auth (issue #170)
042af57
@nijel
Copy link
Member

nijel commented Oct 8, 2013

Very basic support is now implemented in git using python-social-auth, quite a lot of integration work is still missing:

  • Migrate email based registrations to python-social-auth
  • Implement password reset
  • Implement setting password for social only logins
  • Properly redirect after using social login
  • Handle errors when user tries to associate already associated identity (AuthAlreadyAssociated)
  • Get rid of django-registration dependency

nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Remember login url for social auth (issue #170)
e4e2fb1
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Stay in the profile after adding identity (issue #170)
c56fcca
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Nicer rendering of associated identities (issue #170)
fca9b34
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Better rendering of login page (issue #170)
555b9aa
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Migrate old registration based logins to social-auth
c4f9de2 
Issue #170
nijel added a commit that referenced this issue Oct 8, 2013
@nijel
Password storing/verification for email auth (issue #170)
2f0ec81
nijel added a commit that referenced this issue Oct 9, 2013
@nijel
Drop django-registration requirement (issue #170)
f5d2d82
nijel added a commit that referenced this issue Oct 9, 2013
@nijel
Password reset using social-auth
f7cc8f7 
Issue #170
@nijel
Copy link
Member

nijel commented Oct 9, 2013

Feature is implemented, but documentation is still missing, that will be handles as part of issue #376.

@nijel nijel closed this as completed Oct 9, 2013
nijel added a commit that referenced this issue Oct 10, 2013
@nijel
Include GitHub example (issue #170)
0d2e443
@dupuy dupuy mentioned this issue Jul 27, 2014
Closed
@nijel nijel changed the title Support federated login Support federated login [$5 awarded] Feb 21, 2015
@nijel nijel changed the title Support federated login [$5 awarded] Support federated login May 3, 2018
@nijel nijel changed the title Support federated login Support federated login [$5 awarded] May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
4 participants
@nijel @stefanb @Marlinc @schuon