Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "Start new translation" even when not logged in #1950

Closed
TheLastProject opened this issue Apr 7, 2018 · 6 comments
Closed

Show "Start new translation" even when not logged in #1950

TheLastProject opened this issue Apr 7, 2018 · 6 comments
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Milestone
3.0

Comments

@TheLastProject
Copy link
Contributor

TheLastProject commented Apr 7, 2018 •
edited by nijel

So far, every single time I've referred a new translator to the Pext page on Hosted Weblate, they ask "can you add so I can start translating"? The new button is great, but unfortunately only shown when logged in, so many new users who haven't used Weblate before don't see it and get confused :(
@nijel nijel added the enhancement Adding or requesting a new feature. label Apr 9, 2018
@nijel
Copy link
Member

nijel commented Apr 9, 2018

Just to clarify: you don't want unauthenticated users to start new translations, just to be able to see the button, right?

@nijel nijel added help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. labels Apr 9, 2018
@TheLastProject
Copy link
Contributor Author

Yeah, exactly

@comradekingu
Copy link
Contributor

The grayed out "start new translation"-button and the "Log in" could be outlined in the same way, so as to draw a connection between their function.

@piyushmittal25
Copy link

piyushmittal25 commented Apr 20, 2018 •
edited

Hello @TheLastProject :)
Can I take care of this issue and its going to be my first open source contribution.But the problem is I didn't find any new button either after "log in" can you just send me some screenshot or provide extra description please..

@comradekingu
Copy link
Contributor

comradekingu commented Apr 20, 2018 •
edited

@piyushmittal25 :)))))))
That is a different issue. You have to click your way into one of the resources to open up a new translation.

@nijel nijel self-assigned this May 21, 2018
@nijel nijel added this to the 3.0 milestone May 21, 2018
@nijel nijel closed this as completed in 02cbef3 May 21, 2018
@nijel
Copy link
Member

nijel commented May 21, 2018

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see problem with the fix, please comment on this issue.
  • In case you see similar problem, please open separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

nijel added a commit that referenced this issue May 21, 2018
@nijel
Fix tests after fixing #1950
6cd0e59 
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
4 participants
@nijel @TheLastProject @comradekingu @piyushmittal25