Drop support for Python 2.x and Django < 2.2 #2201

nijel · 2018-08-28T09:49:34Z

This has to be done at some point. Eventually it might become problematic to keep the code compatible with Django 1.11 and current release or simply we want to get rid of all the compatibility code for Python 2.

Simplify constructors to use just super()
Remove no longer needed explicit inheritance from object
Remove no longer needed future imports
Increase required Django version and remove no longer needed compatibility code (eg. bulk_create_ignore)
Remove six usage
Remove usage of python_2_unicode_compatible decorators
Use yield from for nesting generators
Add check for Python 2 to Weblate to warn users early
Remove legacy code like avatar cache cleanup

The furthest date for dropping support Django 1.11 is upstream support and it is supported until at least April 2020.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The text was updated successfully, but these errors were encountered:

We want to get rid of Python 2 support in future, so better to tell people to use Python 3 now. Issue #2605 Issue #2201 Signed-off-by: Michal Čihař <michal@cihar.com>

We want to give users early warning on dropping Python 2 support, this way hopefully nobody will be suprised when 4.0 is out next year. Issue #2201 Signed-off-by: Michal Čihař <michal@cihar.com>

nijel · 2019-04-03T17:10:29Z

This has been scheduled to April 2020 in the 4.0 milestone. It will also not support older Django than 2.2, which will be current LTS release by then.

We can get rid of those once we drop support for Django 1.11. See #2201 Signed-off-by: Michal Čihař <michal@cihar.com>

nijel · 2020-02-03T08:10:38Z

We might actually go for whatever Django will include django/django#12332 so that we can remove our workaround for that. That will make us skip LTS 2.2, but I don't see a major issue with that.

Since Python 3.3 all builds are wide, so avoid dealing with that for now. See actions/setup-python#23 See #2201

Issue #2201

Those were needed for Python 2.7. Issue #2201

Support for Python 2 is dropped. Issue #2201

It is more effective than iterating and yielding every item. Issue #2201

Issue #2201

Instead of relying on six. Issue #2201

Avoid using six. Issue #2201

We no longer need six for that. Issue #2201

Remove usage of six as Python 2 compat is gone. Issue #2201

We can now use Python 3 names directly. Issue #2201

Issue #2201

It is no longer used. Issue #2201

Own logic is no longer needed as we require Python 3.5. Issue #2201

Issue #2201

We can use native Django features for this. Issue #2201

Issue #2201

The 0.7.2 has native code for damerau_levenshtein_distance with unicode. Issue #2201

Issue #2201

Now all of them are unicode. Issue #2201

It is not needed with Python 3. Issue #2201

With Python 3 the default inheritance does not have to be specified. Issue #2201

Issue #2201

It was only needed for migrating to Python 3. Issue #2201

github-actions · 2020-02-20T20:42:15Z

Thank you for your report, the issue you have reported has just been fixed.

In case you see a problem with the fix, please comment on this issue.
In case you see similar problem, please open separate issue.
If you are happy with the outcome, consider supporting Weblate by donating.

nijel added the enhancement Adding or requesting a new feature. label Aug 28, 2018

nijel added a commit that referenced this issue Mar 6, 2019

Change install instructions to prefer Python 3

375233c

We want to get rid of Python 2 support in future, so better to tell people to use Python 3 now. Issue #2605 Issue #2201 Signed-off-by: Michal Čihař <michal@cihar.com>

nijel mentioned this issue Mar 13, 2019

UWSGI failing. ImportError: No module named async.timer #2624

Closed

nijel added this to the 4.0 milestone Mar 16, 2019

nijel added a commit that referenced this issue Mar 16, 2019

Add check for Python 2

aeb6543

We want to give users early warning on dropping Python 2 support, this way hopefully nobody will be suprised when 4.0 is out next year. Issue #2201 Signed-off-by: Michal Čihař <michal@cihar.com>

nijel changed the title ~~Drop support for Python 2.x and Django 1.11~~ Drop support for Python 2.x and Django < 2.2 Apr 3, 2019

nijel mentioned this issue Aug 21, 2019

Add support for two-factor authentication #1681

Open

nijel pinned this issue Sep 1, 2019

nijel mentioned this issue Sep 1, 2019

Add Weblate python3statement/python3statement.github.io#258

Merged

nijel mentioned this issue Oct 10, 2019

Bump html2text from 2019.8.11 to 2019.9.26 #3058

Closed

nijel added a commit that referenced this issue Jan 13, 2020

Tests: Silence Django deprecation warnings

aabee39

We can get rid of those once we drop support for Django 1.11. See #2201 Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this issue Feb 20, 2020

Checks: Remove workarounds for narrow builds

ebe3458

Since Python 3.3 all builds are wide, so avoid dealing with that for now. See actions/setup-python#23 See #2201

nijel self-assigned this Feb 20, 2020

nijel mentioned this issue Feb 20, 2020

Drop Python 2 support #3505

Merged

nijel closed this as completed in #3505 Feb 20, 2020

nijel added a commit that referenced this issue Feb 20, 2020

Deps: Require Python 3.5

75649a7

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Remove __future__ imports

e99139a

Those were needed for Python 2.7. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Remove usage of python_2_unicode_compatible

af737b4

Support for Python 2 is dropped. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Utilize yield from

8adafb7

It is more effective than iterating and yielding every item. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Remove conditions on Python version

119245d

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Utils: Use native way to raise exception with custom traceback

c3acd61

Instead of relying on six. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Import StringIO from io

2111d4e

Avoid using six. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Use direct detection of strings

d307c2c

We no longer need six for that. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Use chr instead of six.unichr

641aaeb

We no longer need six for that. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Handle metaclasses natively

1e6e752

Remove usage of six as Python 2 compat is gone. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Avoid using six.moves

571a28d

We can now use Python 3 names directly. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Use assertRaisesRegex directly

59ef5fe

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Deps: Remove six dependency

0acf9b0

It is no longer used. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Formats: Use os.replace

343b564

Own logic is no longer needed as we require Python 3.5. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Deps: Remove Python 2 deps

94f2032

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Remove conditional imports of Python 2 modules

0d5e0f1

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Checks: Remove no longer needed bulk_create_ignore

e7233e2

We can use native Django features for this. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Flags: Remove Python 2 compatibility code

d8e7603

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Deps: Raise jellyfish dependency

a848987

The 0.7.2 has native code for damerau_levenshtein_distance with unicode. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Backup: Remove Django 1.11 compatibility

8a16433

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Avoid using deprecated ugettext

491df0a

Now all of them are unicode. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Remove object inheritance

154f76c

It is not needed with Python 3. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Use simple super()

bb98ae9

With Python 3 the default inheritance does not have to be specified. Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Misc: Remove Django 1.11 compatibility code

d24b096

Issue #2201

nijel added a commit that referenced this issue Feb 20, 2020

Manage: Remove cleanup_avatar_cache

5854c1c

It was only needed for migrating to Python 3. Issue #2201

nijel unpinned this issue Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop support for Python 2.x and Django < 2.2 #2201

Drop support for Python 2.x and Django < 2.2 #2201

nijel commented Aug 28, 2018 •

edited

nijel commented Apr 3, 2019

nijel commented Feb 3, 2020

github-actions bot commented Feb 20, 2020

Drop support for Python 2.x and Django < 2.2 #2201

Drop support for Python 2.x and Django < 2.2 #2201

Comments

nijel commented Aug 28, 2018 • edited

nijel commented Apr 3, 2019

nijel commented Feb 3, 2020

github-actions bot commented Feb 20, 2020

nijel commented Aug 28, 2018 •

edited