Checks performed when saving translation should be performed when saving suggestions too

[emmapeel2]

Describe the bug
When I accept other translators suggestions, the checks about 'trailing newline', 'trailing space', 'invalid XML' etc start to appear. This tests should be performed before the user adds the suggestion, and prevent the saving of said suggestion instead.
This will save reviewing time, and also will help translators to learn not to make the mistakes.

To Reproduce
Steps to reproduce the behavior:

1. Add a translation that will provoke and error (depending on the tests you have selected)
2. Click on Save
3. A message appears saying there is an error
4. Click on Suggest

The suggestion gets saved without problem

Expected behavior
The error message should appear again and prevent the suggestion to be saved (or have an error flag but that will be really complicated I think)

Server configuration and status

• Weblate weblate-3.2.2
• Python 2.7.15
• Django 1.11.16

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[nijel]

Just to clarify - the translation is saved as well, it's just the message is shown and you stay on same string. But indeed the suggestions should behave similarly.

[emmapeel2]

yeah the problem is that when i accept suggestions i dont have this information neither. It would be nice if the suggestions were flagged somehow as not passing a check.
otherwise, each time I go through the pending suggestions, i get a lot of error messages aftwerwards, not when I am looking at the suggestions.

and happy birthday to the ticket!

[github-actions]

Thank you for your report, the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see similar problem, please open separate issue.
• If you are happy with the outcome, consider supporting Weblate by donating.