Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS support #3028

Closed
ersvltan opened this issue Sep 16, 2019 · 8 comments
Closed

CORS support #3028

ersvltan opened this issue Sep 16, 2019 · 8 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@ersvltan
Copy link

ersvltan commented Sep 16, 2019

Is your feature request related to a problem? Please describe.
I am sending a request for a Weblate, and the response does not have Access-Control-Allow-Origin headers, and therefore the browser rejects responses from the server with the error Access to XMLHttpRequest at * from origin 'http://localhost' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: Redirect is not allowed for a preflight request.
Can Weblate provide any solution for setting Access-Control-Allow-Origin headers?

Describe the solution you'd like
Currently I am adding a corsheaders library to settings.py. But it would be easier in the future to have CORS headers support built-in.

Describe alternatives you've considered
No alternatives.

Additional context
No context

@nijel
Copy link
Member

nijel commented Sep 16, 2019

This is intentional setup, can you please clarify what is your use case for this

@nijel nijel added the question This is more a question for the support than an issue. label Sep 16, 2019
@ersvltan
Copy link
Author

This is intentional setup, can you please clarify what is your use case for this

updated description.

@nijel
Copy link
Member

nijel commented Sep 17, 2019

I don't think it's reasonable to set it on whole Weblate, it might be better just on selected endpoints you are using?

@ersvltan
Copy link
Author

I don't think it's reasonable to set it on whole Weblate, it might be better just on selected endpoints you are using?

What do you mean by selected endpoints ?

@nijel
Copy link
Member

nijel commented Sep 27, 2019

Selected URLs. Can you please describe what is your use case? Why do you need to do CORS against Weblate?

@stale
Copy link

stale bot commented Oct 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Nobody will work on this. label Oct 7, 2019
@stale stale bot closed this as completed Oct 11, 2019
@nijel nijel added enhancement Adding or requesting a new feature. and removed question This is more a question for the support than an issue. wontfix Nobody will work on this. labels Feb 27, 2023
@nijel nijel self-assigned this Feb 27, 2023
@nijel nijel added this to the 4.16 milestone Feb 27, 2023
@nijel nijel reopened this Feb 27, 2023
@nijel
Copy link
Member

nijel commented Feb 27, 2023

Reopening based on #6665 and WeblateOrg/docker#1694

@nijel nijel closed this as completed in 9335552 Feb 27, 2023
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit to WeblateOrg/docker that referenced this issue Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants