Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend screenshots API [$100 awarded] #3076

Closed
nijel opened this issue Sep 30, 2019 · 12 comments · Fixed by #3665
Closed

Extend screenshots API [$100 awarded] #3076

nijel opened this issue Sep 30, 2019 · 12 comments · Fixed by #3665
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@nijel
Copy link
Member

nijel commented Sep 30, 2019

Is your feature request related to a problem? Please describe.
The screenshots API is currently limited to listing screenshots and does not support adding new ones.

Describe the solution you'd like
Extend API to allow:

  • List screenshots per component
  • Add new screenshots
  • Associate strings with screenshots

Additional context
https://docs.weblate.org/en/latest/api.html#screenshots

Blocked by #2831

@nijel nijel added the enhancement Adding or requesting a new feature. label Sep 30, 2019
@nijel nijel changed the title Extend screenshots API Extend screenshots API [$100] Mar 4, 2020
@nijel nijel added the bounty label Mar 4, 2020
@brymut
Copy link
Contributor

brymut commented Mar 10, 2020

Hi @nijel , having a look at this today. May I please get assigned to it?

@nijel
Copy link
Member Author

nijel commented Mar 10, 2020

You're welcome, I've just assigned it to you.

@brymut
Copy link
Contributor

brymut commented Mar 10, 2020

Thank you

@brymut
Copy link
Contributor

brymut commented Mar 12, 2020

Hi again @nijel , I've finally had a look and come up with some possible solutions. However, I have a question regarding

  • List screenshots per component

Given the current API organisation and the viewset pattern implemented. Would you also find it fit to add this under the translations component API with the request pattern
GET /api/components/(string:project)/(string:component)/screenshots/
instead of
GET /api/screenshots/(string:project)/(string:component)/
as per my initial look at this would require fewer changes and subsequently complexity to the API views implementation.
What do you think?

@nijel
Copy link
Member Author

nijel commented Mar 12, 2020

GET /api/components/(string:project)/(string:component)/screenshots/

Yes, this makes sense to use this approach.

@jammmet
Copy link

jammmet commented Mar 24, 2020

How are you getting on @brymut?

@brymut
Copy link
Contributor

brymut commented Mar 24, 2020

Hi @jammmet, still working on some test cases. Unfortunately got overwhelmed with other stuff over the past week but should be submitting a pull request by Thursday.

Edit: Apologies for the delay, getting on it today.

@mikemassing
Copy link

Hi @brymut, I would be happy to test if needed.

@jammmet
Copy link

jammmet commented Mar 28, 2020

Thursday

Great. Stay safe in Nairobi (I'm based here). Let me know when you have something to test (I posted the bounty)

@brymut
Copy link
Contributor

brymut commented Apr 6, 2020

Hi, @jammmet @mikemassing finally got a chance to submit the PR, apologies for the delay, it took longer than I would have liked it to because of some previous commitments and the current situation.

The PR should be available now for review if you'd like to have a look and test and stay safe too. 👍
(Nice to know you're based here too 🙂)

@nijel nijel added this to the 4.0 milestone Apr 7, 2020
@nijel
Copy link
Member Author

nijel commented Apr 7, 2020

Implemented in #3665

@nijel nijel closed this as completed Apr 7, 2020
@github-actions
Copy link

github-actions bot commented Apr 7, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see similar problem, please open separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

@nijel nijel changed the title Extend screenshots API [$100] Extend screenshots API [$100 awarded] Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants