Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend screenshots API #3761

Closed
nijel opened this issue Apr 20, 2020 · 1 comment · Fixed by #4196
Closed

Extend screenshots API #3761

nijel opened this issue Apr 20, 2020 · 1 comment · Fixed by #4196
Assignees
@SaptakS
Labels
enhancement Adding or requesting a new feature.
Projects
API improvements
Milestone
4.2

Comments

@nijel
Copy link
Member

nijel commented Apr 20, 2020 •
edited

Is your feature request related to a problem? Please describe.
The API for screenshots is still missing some bits:

  • Delete screenshots, DELETE /api/screenshots/(int: id)/
  • Remove unit association from screenshot, DELETE /api/screenshots/(int: id)/units/(int: unitid)/
  • Edit screenshot, PUT/PATCH /api/screenshots/(int: id)/

Describe the solution you'd like
Complete CRUD for screenshots.

Additional context
Followup for #3076

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@nijel nijel added the enhancement Adding or requesting a new feature. label Apr 20, 2020
@nijel nijel changed the title Extend screenshots Extend screenshots API Apr 20, 2020
@nijel nijel added this to To do in API improvements May 15, 2020
@SaptakS SaptakS self-assigned this Jul 18, 2020
@SaptakS SaptakS mentioned this issue Jul 19, 2020
Merged
4 tasks
@nijel nijel added this to the 4.2 milestone Aug 6, 2020
API improvements automation moved this from To do to Done Aug 6, 2020
nijel pushed a commit that referenced this issue Aug 6, 2020
@SaptakS
API: Extends screenshot API (#4196)
aa670b7 
* Extends screenshot API
* Adds tests for proper errors

Fixes #3761
@github-actions
Copy link

github-actions bot commented Aug 6, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaptakS SaptakS

Labels
enhancement Adding or requesting a new feature.
Projects
API improvements
Status: Done
API improvements
  
Done
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Extends screenshot API SaptakS/weblate
2 participants
@nijel @SaptakS