-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show rendered text from size check [$25 awarded] #3143
Comments
Thank you for your report, the issue you have reported has just been fixed.
|
I haven't been able to test this on an environment, so I'm going to ask things based on what I'm figuring out via reading the code:
|
We currently don't have UI for this. All we do is to show failed checks and this now includes the rendered images. |
A friend of mine made a temp server and I've seen the current status (master from 3.11-dev, taken yesterday). I was unable to get the proper font-family being read out, all the samples were still displaying SourceSansPro. Window size and font size were read properly. He also had this error: [error] 158#158: *538 open() "/app/data/static/font-source/WOFF2/TTF/SourceCodePro-Semibold.ttf.woff2" failed (2: No such file or directory), client: CLEANED, server: , request: "GET /static/font-source/WOFF2/TTF/SourceCodePro-Semibold.ttf.woff2 HTTP/1.1", host: "CLEANED", referrer: "CLEANEDstatic/font-source/source-code-pro.css?v=3.11-dev" Though I do have seen how does it look like. Maybe making it a permanent toggeable window, like Glossary and Source information, would be nice in the future (though I'd be worried if this was implemented in Zen, even if that would be much nicer for the translator, it could increase the server load). |
Hmm, I've just tested it and it seems to work properly for me. I've recently fixed possible issue with using bold font faces, but you should still end up with correct family. |
I tried two different fonts: A custom one I made, which is my target font and should be marked as Regular, and a copy of Stencil from my Windows Fonts folder just to be sure I wasn't breaking anything with the font. Both fonts did not appear in the render. |
I just went to the sample server again and my custom font worked now, maybe there was a caching problem of some sorts. So now I'm seeing the previews whenever the check fails with the proper font. The current system works with the checks, but I'd be interested on seeing this window at all times. That's what's making me doubt over if I should accept or reject the changes for the bounty. |
Can you please open separate issue for that? |
Split from #3140 by @IlDucci
Good evening. I would like to request certain upgrades and additions to the string length rendering checks:
Is your feature request related to a problem? Please describe.
I find two problems when it comes to check the renderings:
Describe the solution you'd like
Describe alternatives you've considered
Additional context
There's not much else I can think of right now.
The text was updated successfully, but these errors were encountered: