Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show rendered text from size check [$25 awarded] #3143

Closed
nijel opened this issue Oct 23, 2019 · 8 comments
Closed

Show rendered text from size check [$25 awarded] #3143

nijel opened this issue Oct 23, 2019 · 8 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@nijel
Copy link
Member

nijel commented Oct 23, 2019

Split from #3140 by @IlDucci

Good evening. I would like to request certain upgrades and additions to the string length rendering checks:

Is your feature request related to a problem? Please describe.
I find two problems when it comes to check the renderings:

  • Call me micromanager, but sometimes I'd like to see the actual sample of the rendered dialogue. Maybe I have a word that's too long and that's going over the limit because of that reason, but I won't be able to know it's the problem unless I actually see the rendered sample. Or maybe I'd like to do the line breaks manually to improve the text flow. Is there a way to display the sample renders to the user?

Describe the solution you'd like

  • Display the font rendering samples as graphics during the translation/revision process.

Describe alternatives you've considered

  • About the font rendering, probably the best way to avoid a server overload is to make the graphic display on-demand, by the touch of a button, for example. Having a lot of images rendered and displayed could cause havoc in Zen mode. But if the actual TTF can be used as a web font, maybe the system could use it to display on-the-fly modifications, which could even work in Zen mode.

Additional context
There's not much else I can think of right now.

@nijel nijel added the enhancement Adding or requesting a new feature. label Oct 23, 2019
@nijel nijel changed the title Show rendered text from check Show rendered text from size check Oct 23, 2019
@nijel nijel added this to the 3.11 milestone Dec 16, 2019
@nijel nijel changed the title Show rendered text from size check Show rendered text from size check [$25] Dec 18, 2019
@nijel nijel added the bounty label Dec 18, 2019
@nijel nijel self-assigned this Jan 17, 2020
@nijel nijel closed this as completed in 34ebd52 Jan 18, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see similar problem, please open separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

@IlDucci
Copy link

IlDucci commented Jan 25, 2020

I haven't been able to test this on an environment, so I'm going to ask things based on what I'm figuring out via reading the code:

  • Is it possible to have access to the preview at all times, not only when the limits are reached?

@nijel
Copy link
Member Author

nijel commented Jan 26, 2020

We currently don't have UI for this. All we do is to show failed checks and this now includes the rendered images.

@IlDucci
Copy link

IlDucci commented Jan 26, 2020

A friend of mine made a temp server and I've seen the current status (master from 3.11-dev, taken yesterday). I was unable to get the proper font-family being read out, all the samples were still displaying SourceSansPro. Window size and font size were read properly.

He also had this error: [error] 158#158: *538 open() "/app/data/static/font-source/WOFF2/TTF/SourceCodePro-Semibold.ttf.woff2" failed (2: No such file or directory), client: CLEANED, server: , request: "GET /static/font-source/WOFF2/TTF/SourceCodePro-Semibold.ttf.woff2 HTTP/1.1", host: "CLEANED", referrer: "CLEANEDstatic/font-source/source-code-pro.css?v=3.11-dev"

Though I do have seen how does it look like. Maybe making it a permanent toggeable window, like Glossary and Source information, would be nice in the future (though I'd be worried if this was implemented in Zen, even if that would be much nicer for the translator, it could increase the server load).

@nijel
Copy link
Member Author

nijel commented Jan 30, 2020

Hmm, I've just tested it and it seems to work properly for me. I've recently fixed possible issue with using bold font faces, but you should still end up with correct family.

@IlDucci
Copy link

IlDucci commented Jan 30, 2020

I tried two different fonts: A custom one I made, which is my target font and should be marked as Regular, and a copy of Stencil from my Windows Fonts folder just to be sure I wasn't breaking anything with the font. Both fonts did not appear in the render.

@IlDucci
Copy link

IlDucci commented Jan 31, 2020

I just went to the sample server again and my custom font worked now, maybe there was a caching problem of some sorts. So now I'm seeing the previews whenever the check fails with the proper font.

The current system works with the checks, but I'd be interested on seeing this window at all times. That's what's making me doubt over if I should accept or reject the changes for the bounty.

@nijel
Copy link
Member Author

nijel commented Jan 31, 2020

Can you please open separate issue for that?

@nijel nijel changed the title Show rendered text from size check [$25] Show rendered text from size check [$25 awarded] Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants