-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholders for rendered size check [$50 awarded] #3140
Comments
Can you please keep it one feature per issue? I've separated #3143 |
Sorry about that. |
Can you please clarify how the control codes look like? To me it looks like string replacement would be better fit for this than manually specifying width. That way it will also look better with #3143. |
Right now we have a few, so let me write some similar examples (I'm a translator, so I cannot speak about the naming decisions here)... <COLOR_RED> as an example for coloring, <PORTRAIT_(character-name)_(number)> for displaying portraits and <PROTAGONIST_FULL_NAME> for displaying a name and a surname. The first and second cases should count as zero, and the third one, well... I personally was thinking of adding the equal value to the max amount of chars available in memory (For example, 8 chars for the name + the space of the space character + 8 chars for the surname). |
Effectively, #3546 is prerequisite here to support space and other special chars in the strings. |
Thank you for your report, the issue you have reported has just been fixed.
|
Docs was missing and the cache key method was duplicated. Issue #3140
I've found an error: it is not possible to add more than one empty entries in the replacements string. #, replacements:{COLOR-GREY}:"" Makes any elements called {COLOR-GREY} dissappear. This is a behavior I would like to keep. Writing this: Causes a server error when pulling the new changes, and the server considers it is up-to-date. |
Can you please open separate issue for that? Preferably including the traceback. Most likely it's a bug in the parser introduced by #3546 |
Still, this doesn't seem to trigger the error described in #3140.
Good evening. I would like to request certain upgrades and additions to the string length rendering checks:
Is your feature request related to a problem? Please describe.
I find two problems when it comes to check the renderings:
Call me micromanager, but sometimes I'd like to see the actual sample of the rendered dialogue. Maybe I have a word that's too long and that's going over the limit because of that reason, but I won't be able to know it's the problem unless I actually see the rendered sample. Or maybe I'd like to do the line breaks manually to improve the text flow. Is there a way to display the sample renders to the user?Describe the solution you'd like
Display the font rendering samples as graphics during the translation/revision process.Describe alternatives you've considered
About the font rendering, probably the best way to avoid a server overload is to make the graphic display on-demand, by the touch of a button, for example. Having a lot of images rendered and displayed could cause havoc in Zen mode. But if the actual TTF can be used as a web font, maybe the system could use it to display on-the-fly modifications, which could even work in Zen mode.Additional context
There's not much else I can think of right now.
The text was updated successfully, but these errors were encountered: