Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace httpretty by responses #3536

Closed
nijel opened this issue Feb 29, 2020 · 3 comments · Fixed by #3542
Closed

Replace httpretty by responses #3536

nijel opened this issue Feb 29, 2020 · 3 comments · Fixed by #3542
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Milestone
4.0

Comments

@nijel
Copy link
Member

nijel commented Feb 29, 2020 •
edited

Is your feature request related to a problem? Please describe.
Now that all Weblate code uses requests, it's time to get rid of httpretty dependency and use responses instead.

We currently depend on both, new tests are using responses and old ones httpretty. The httpretty is suffering for long by gabrielfalcao/HTTPretty#345

Describe the solution you'd like
Replace httpretty usage by responses. It should be pretty straightforward as the API is compatible.
@nijel nijel added enhancement Adding or requesting a new feature. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. labels Feb 29, 2020
@nijel nijel added this to the 4.0 milestone Feb 29, 2020
nijel added a commit that referenced this issue Feb 29, 2020
@nijel
Tests: Use responses to mock akismet
23b0035 
Issue #3536
@nijel
Copy link
Member Author

nijel commented Feb 29, 2020 •
edited

I've done this for one module in 23b0035.

If you want to help with this, even partial pull requests are great, start with converting one file.

@comradekingu comradekingu mentioned this issue Mar 2, 2020
Merged
@nijel
Copy link
Member Author

nijel commented Mar 2, 2020

There is WIP implementation in #3542

nijel added a commit that referenced this issue Mar 4, 2020
@nijel
Replace HTTPretty with Responses (#3542)
5af1413 
* Replace HTTPretty with Responses

Fixes #3536

Co-authored-by: Michal Čihař <michal@cihar.com>
@github-actions
Copy link

github-actions bot commented Mar 4, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see similar problem, please open separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

@nijel nijel self-assigned this Mar 4, 2020
nijel added a commit that referenced this issue Mar 4, 2020
@nijel
Tests: Use json support in responses
3ef42cf 
This make the code easier to read and maintain.

Issue #3536
nijel added a commit that referenced this issue Mar 4, 2020
@nijel
Deps: Remove httpretty
f6e6e6c 
Issue #3536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Replace HTTPretty with Responses comradekingu/Weblate
1 participant
@nijel