Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve date selection for reports #3558

Closed
nijel opened this issue Mar 4, 2020 · 16 comments · Fixed by #11826
Closed

Improve date selection for reports #3558

nijel opened this issue Mar 4, 2020 · 16 comments · Fixed by #11826
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. ux Issues related to user experience.
Milestone

Comments

@nijel
Copy link
Member

nijel commented Mar 4, 2020

Is your feature request related to a problem? Please describe.

Current reporting period selection is not user-friendly:

image

Describe the solution you'd like

I'd like to see something like this:

image

@nijel nijel added enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. ux Issues related to user experience. labels Mar 4, 2020
@msanden
Copy link

msanden commented Apr 3, 2020

Can I claim this issue?

@nijel
Copy link
Member Author

nijel commented Apr 3, 2020

Sure, you're welcome.

@msanden msanden removed their assignment Apr 4, 2020
@rajat641
Copy link
Contributor

Hi @nijel , Can I work on this. There is no update on this for a long time.

@nijel
Copy link
Member Author

nijel commented May 27, 2020

You're welcome! Yes, there are about two hundredths of issues without an update for a long time ;-)

@rajat641
Copy link
Contributor

Hi @nijel ,
Today I explored on how to implement the above change and managed to find an already written JS component implementing the above feature. Here is the reference link http://www.daterangepicker.com/#config.
It looked somehow like this on my local machine-
image
Please ignore the styling details as it's just done for demonstration/clarification purposes to you.
It doesn't have a This Year and Next Year option(as given in the requirements image attached above) and I tried adding it but I did work out as its predefined.

I'm not sure If I can change styling or not as its already predefined. I haven't worked on UX before so please let me know if I'm following the right path or I have to write everything from scratch or maybe learn something else. I thought of using some Bootstrap/JQuery Plugin but I am not very confident about my approach.

nijel added a commit that referenced this issue May 28, 2020
@nijel
Copy link
Member Author

nijel commented May 28, 2020

Writing from scratch is certainly not needed, this one seems like a good choice (it has compatible license and it seems to be using Bootstrap, so hopefully it will not require much of additional styling).

We use yarn to manage the deps, see https://docs.weblate.org/en/latest/contributing/frontend.html for more info on that and other frontend development hints (I've just pushed some improvements to that, it will take few minutes to be fully up to date).

@nijel nijel added the hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. label Aug 18, 2020
@nijel nijel added the help wanted Extra attention is needed. label Sep 25, 2020
@nijel nijel changed the title Improve date selection for reports Improve date selection for reports [$7] Dec 1, 2020
@nijel nijel added the bounty label Dec 1, 2020
@nijel nijel changed the title Improve date selection for reports [$7] Improve date selection for reports [$12] Jan 6, 2021
@nijel nijel changed the title Improve date selection for reports [$12] Improve date selection for reports [$17] Feb 1, 2021
@nijel nijel changed the title Improve date selection for reports [$17] Improve date selection for reports [$22] Mar 1, 2021
@nijel nijel changed the title Improve date selection for reports [$22] Improve date selection for reports [$27] Apr 6, 2021
@nijel nijel changed the title Improve date selection for reports [$27] Improve date selection for reports [$32] May 1, 2021
@github-actions github-actions bot removed the bounty label Jan 7, 2022
@WofWca
Copy link
Contributor

WofWca commented Apr 29, 2022

Is it that not user-friendly? Nowadays browsers have pretty solid date pickers built in.

image

Maybe it's about simply making the inputs less W I D E.

@nijel
Copy link
Member Author

nijel commented Apr 29, 2022

The date selection itself is okay, but seeing directly chosen date range would be definitely nicer than current drop-down and two inputs...

@akhilsahuji
Copy link

akhilsahuji commented Apr 14, 2024

@nijel is this feature is still needed ?

can i work on it ?

@nijel
Copy link
Member Author

nijel commented Apr 16, 2024

Yes, nobody has contributed this so far.

@akhilsahuji
Copy link

akhilsahuji commented Apr 18, 2024

@nijel could you hint me on reproducing the report section mentioned above? I have set up the demo project, but I am unable to locate the specific report section shown in the screenshot.

@akhilsahuji
Copy link

akhilsahuji commented Apr 21, 2024

i am guessing that we are talking about Translation progress reporting 🤞

@nijel
Copy link
Member Author

nijel commented Apr 22, 2024

Yes, Insights / Translation reports in the menu. Currently, there is a dropdown for range selection and two date inputs. Instead, there should be just two date inputs sent to the backend and client-side selection of the ranges. It should probably also include time to make it explicit (this is a frequent question we get).

Here are some additional examples of how it could look:

image

image

@harriebird
Copy link
Collaborator

Hi guys, check my PR #11826 for this issue.

@nijel nijel linked a pull request Jun 17, 2024 that will close this issue
5 tasks
@nijel
Copy link
Member Author

nijel commented Jun 17, 2024

Implemented by #11826

@nijel nijel closed this as completed Jun 17, 2024
@nijel nijel changed the title Improve date selection for reports [$32] Improve date selection for reports Jun 17, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@nijel nijel added this to the 5.6 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. ux Issues related to user experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants