Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove django.contrib.sites usage #4250

Closed
3 tasks done
nijel opened this issue Aug 3, 2020 · 1 comment
Closed
3 tasks done

Remove django.contrib.sites usage #4250

nijel opened this issue Aug 3, 2020 · 1 comment
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
4.2

Comments

@nijel
Copy link
Member

nijel commented Aug 3, 2020 •
edited

I don't think Weblate will ever support multiple domains, so using django.contrib.sites seems to bring only complexity and no benefits.
@nijel nijel added the enhancement Adding or requesting a new feature. label Aug 3, 2020
@nijel nijel added this to the 4.2 milestone Aug 3, 2020
@nijel nijel self-assigned this Aug 3, 2020
nijel added a commit to WeblateOrg/docker that referenced this issue Aug 4, 2020
@nijel
Provide fallback for WEBLATE_SITE_DOMAIN
7ceaa5e 
This is to keep compatibility with existing setups for upcoming 4.2
release.

Whent WEBLATE_SITE_DOMAIN is not set, it uses first entry from
WEBLATE_ALLOWED_HOSTS.

See WeblateOrg/weblate#4250
@nijel nijel closed this as completed in 2eaa906 Aug 4, 2020
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

nijel added a commit to WeblateOrg/scripts that referenced this issue Aug 4, 2020
@nijel
Adjust installation to changed site location
1e5ee0a 
See WeblateOrg/weblate#4250
nijel added a commit to WeblateOrg/docker-compose that referenced this issue Aug 4, 2020
@nijel
Set site domain for tests
5563aa6 
Needed for 4.2 tests.

See WeblateOrg/weblate#4250
nijel added a commit that referenced this issue Aug 4, 2020
@nijel
Docs: Remove description of Django sites
4785261 
It was forgotten here.

Issue #4250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
1 participant
@nijel