Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab merge requests without forking repo #4285

Closed
franta opened this issue Aug 7, 2020 · 8 comments
Closed

Gitlab merge requests without forking repo #4285

franta opened this issue Aug 7, 2020 · 8 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@franta
Copy link

franta commented Aug 7, 2020

Is your feature request related to a problem? Please describe.
Gitlab pipelines from merge requests.
Weblate create merge request, gitlab trigger pipeline, but pipeline fail because different repo without required settings (gitlab ci variables).

Describe the solution you'd like
I completely understand why Weblate fork repo. Translator don't need commit permissions to original repo, but still can propose changes. Well known workflow eg. on public github.
But this solution is problematic for us, mainly because of problem described above.

Proposal is to add possibility (settings in project, component, special vcs type gitlab-nofork ... not sure - for us it's not problem to configure it globally) to create branch in original repo.

Our workflow is "everyone" (internal developers) can commit to repository and maintainers merge proposed changes to protected branches.

@nijel nijel added the question This is more a question for the support than an issue. label Aug 7, 2020
@nijel
Copy link
Member

nijel commented Aug 7, 2020

The option is already there, just set the push branch. See https://docs.weblate.org/en/latest/admin/continuous.html#push-changes

@github-actions
Copy link

github-actions bot commented Aug 7, 2020

This issue looks like a support question. We try to answer these reasonably fast, but in case you are looking for faster resolution, please consider purchasing support subscription and make Weblate stronger.

@georgescumihai
Copy link

georgescumihai commented Aug 8, 2020

Following the instructions for Github at https://docs.weblate.org/en/latest/admin/continuous.html#push-changes
I am unable to configure Weblate to push to a different branch in the same repo, and create a Pull Request
I get the following error: fatal: no path specified; see 'git help pull' for valid url syntax (128)

Weblate 4.1.1, Docker Image
My component configurations:
Version control system: Github
Source code repository: ssh to the repo
Repository branch: develop
Repository push URL: empty
Push branch: weblate-translations
Repository browser: empty string

Weblate is throwing this error when the manual push button is tapped or I add a different translations language which triggers a local commit. : fatal: no path specified; see 'git help pull' for valid url syntax (128)

Also the local branch is develop instead of weblate-translations

If I set the git Repository push URL, then it will create a fork and will create a PR from the fork when push is tapped.

@nijel
Copy link
Member

nijel commented Aug 17, 2020

Can you please enable verbose logging of VCS operations to see which of the operations did fail?

Changing LOGGING in settings.py:

    "weblate.vcs": {"handlers": [DEFAULT_LOG], "level": "DEBUG"},

@adhamelsabbagh
Copy link

i have the same problem

@georgescumihai
Copy link

I will try later this week again with the log level for vcs.

@nijel
Copy link
Member

nijel commented Aug 18, 2020

Another option is to configure Sentry integration. It would collect such errors with more details.

@nijel nijel added bug Something is broken. and removed question This is more a question for the support than an issue. labels Aug 18, 2020
@nijel nijel added this to the 4.2 milestone Aug 18, 2020
@nijel nijel self-assigned this Aug 18, 2020
@nijel nijel closed this as completed in ea7c3d3 Aug 18, 2020
nijel added a commit that referenced this issue Aug 18, 2020
The push URL might have to be set in some cases.

Issue #4285
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

4 participants