Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in the cleanup addon on XLIFF files #4338

Closed
sentry-io bot opened this issue Aug 19, 2020 · 2 comments
Closed

Crash in the cleanup addon on XLIFF files #4338

sentry-io bot opened this issue Aug 19, 2020 · 2 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented Aug 19, 2020

Sentry Issue: WEBLATE-4KK

ValueError: Element is not a child of this node.
(6 additional frame(s) were not displayed)
...
  File "weblate/addons/base.py", line 156, in post_configure
    self.post_update(component, "")
  File "weblate/addons/base.py", line 334, in post_update
    self.update_translations(component, previous_head)
  File "weblate/addons/cleanup.py", line 141, in update_translations
    translation.store,
  File "weblate/addons/cleanup.py", line 120, in update_lisa
    storage.store.body.remove(unit.xmlelement)
  File "src/lxml/etree.pyx", line 943, in lxml.etree._Element.remove
@nijel nijel added the bug Something is broken. label Aug 19, 2020
@nijel
Copy link
Member

nijel commented Aug 19, 2020

This happens when XLIFF groups are used, related to #2482

@nijel nijel added this to TODO in File format support via automation Aug 19, 2020
nijel added a commit to WeblateOrg/test that referenced this issue Aug 19, 2020
@nijel nijel added this to the 4.2.1 milestone Aug 19, 2020
@nijel nijel self-assigned this Aug 19, 2020
@nijel nijel closed this as completed in 601aabf Aug 19, 2020
File format support automation moved this from TODO to Done Aug 19, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
Development

No branches or pull requests

1 participant