Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You will be shown that there are still suggestions for deletion. #4423

Closed
baffclan opened this issue Sep 1, 2020 · 2 comments
Closed

You will be shown that there are still suggestions for deletion. #4423

baffclan opened this issue Sep 1, 2020 · 2 comments
Labels
bug Something is broken.
Milestone
4.3

Comments

@baffclan
Copy link
Contributor

baffclan commented Sep 1, 2020

Describe the bug
You will be shown that there are still suggestions for deletion.

To Reproduce

Steps to reproduce the behavior:

  1. I made a translation suggestion.
  2. After that, I removed my suggestion as the appropriate translation was adopted.
    see: https://hosted.weblate.org/translate/weblate/documentation/ja/?checksum=185d62c927e34b48#history

https://hosted.weblate.org/projects/weblate/documentation/ja/
"Strings status" said:

5 ■ Strings with suggestions — 25 words

and Click this link.

No string matched your search!

Expected behavior

5 ■ Strings with suggestions — 25 words

This should not be displayed.
@nijel nijel added the bug Something is broken. label Sep 1, 2020
@nijel nijel added this to the 4.3 milestone Sep 1, 2020
@nijel nijel closed this as completed in 3be4e17 Sep 1, 2020
nijel added a commit that referenced this issue Sep 1, 2020
@nijel
Suggestion: Apply fast delete to suggestion and votes
535efa9 
Needed to restore performance after adding post_delete handler for
Suggestion. It needs additional care to handle ordering correctly.

See #4423
@github-actions
Copy link

github-actions bot commented Sep 1, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

@baffclan
Copy link
Contributor Author

baffclan commented Sep 3, 2020

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken.
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
2 participants
@nijel @baffclan