Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue of user list sorting #4452

Closed
baffclan opened this issue Sep 7, 2020 · 6 comments · Fixed by #4509
Closed

issue of user list sorting #4452

baffclan opened this issue Sep 7, 2020 · 6 comments · Fixed by #4509
Assignees
@prashanttholia
Labels
bug Something is broken. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam.
Milestone
4.3

Comments

@baffclan
Copy link
Contributor

baffclan commented Sep 7, 2020

Describe the bug
issue of user list sorting

To Reproduce
Steps to reproduce the behavior:

  1. Open Weblate user page
    https://hosted.weblate.org/user/
  2. Cange Date_Join Old->New
    https://hosted.weblate.org/user/?q=&sort_by=date_joined
    Topest user is @nijel
  3. Goto Page bottom, and click [>|]
    list number is 472/472
    Last user is @nijel
    url is https://hosted.weblate.org/user/?page=472&limit=50
    lost a "sort_by=date_joined"

Expected behavior
Opens
https://hosted.weblate.org/user/?page=472&limit=50&sort_by=date_joined

Additional context
Reproduce with Weblate 4.3-dev
Similar to 4369.
@nijel nijel added bug Something is broken. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. labels Sep 7, 2020
@nijel nijel added this to the 4.3 milestone Sep 7, 2020
@prashanttholia
Copy link
Contributor

Hi, I'd like to work on this issue.

@nijel
Copy link
Member

nijel commented Sep 10, 2020

@prashant-tholia you're welcome, I've just assigned this issue to you.

@prashanttholia
Copy link
Contributor

@nijel Thanks.

@prashanttholia prashanttholia mentioned this issue Sep 13, 2020
Merged
@nijel nijel linked a pull request Sep 14, 2020 that will close this issue
User List Sorting Fix #4509
Merged
nijel added a commit that referenced this issue Sep 14, 2020
@prashanttholia @nijel
User List Sorting Fix (#4509)
da1b8c4 
Fix user list sorting issue. Retain search term and sort order in URL query string on click on page navigator buttons.

Fixes #4452

Co-authored-by: Michal Čihař <michal@cihar.com>
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

@baffclan
Copy link
Contributor Author

Cannot reproduce this problem.
Thanks for fixing this!

Er, another one.
Editing a position counter will cause a sort option to be lost.
See #4369

BElluu said:
I can look at this :)

nijel added a commit that referenced this issue Sep 15, 2020
@nijel
Users: Fix editing offset while browsing
2b00a24 
Issue #4452
@nijel
Copy link
Member

nijel commented Sep 15, 2020

Fixed in 2b00a24, thanks for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashanttholia prashanttholia

Labels
bug Something is broken. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam.
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

User List Sorting Fix prashanttholia/weblate
3 participants
@nijel @baffclan @prashanttholia