Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download translation file as CSV - extra single quotes #4488

Closed
ss-gxp opened this issue Sep 11, 2020 · 6 comments
Closed

Download translation file as CSV - extra single quotes #4488

ss-gxp opened this issue Sep 11, 2020 · 6 comments
Labels
question This is more a question for the support than an issue.
Milestone
4.3

Comments

@ss-gxp
Copy link

ss-gxp commented Sep 11, 2020

Version: 4.2.2 (docker image weblate/weblate)

Everything is fine in the web interface:

weblate-2

But extra quotes appear when downloading CSV:

weblate-3
@nijel nijel added the question This is more a question for the support than an issue. label Sep 11, 2020
@nijel
Copy link
Member

nijel commented Sep 11, 2020

Unfortunately, this is intentional. Without the additional quote, Excel interprets the string as formula. See 1216f65 and https://hackerone.com/reports/223344.

@github-actions
Copy link

This issue looks like a support question. We try to answer these reasonably fast, but in case you are looking for faster resolution, please consider purchasing support subscription and make Weblate stronger.

@ss-gxp
Copy link
Author

ss-gxp commented Sep 11, 2020

Clear.
But when loading back, the quotes were not stripped.

weblate-5

@ss-gxp
Copy link
Author

ss-gxp commented Sep 11, 2020

An api parameter would solve the problem.

Thanks for the clarification.

@ss-gxp ss-gxp closed this as completed Sep 11, 2020
@github-actions
Copy link

The issue you have reported seems to be resolved now.

  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

nijel added a commit that referenced this issue Sep 11, 2020
@nijel
Formats: Reverse Excel escaping when parsing CSV file
7477308 
The escaping was introduced to avoid code execution in Excel, and the
loading code should strip that.

See #4488
@nijel nijel added this to the 4.3 milestone Sep 11, 2020
@nijel
Copy link
Member

nijel commented Sep 11, 2020

But when loading back, the quotes were not stripped.

Good point, I've fixed this in 7477308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question This is more a question for the support than an issue.
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
2 participants
@nijel @ss-gxp