Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve translation propagation performance #4661

Closed
nijel opened this issue Oct 7, 2020 · 1 comment
Closed

Improve translation propagation performance #4661

nijel opened this issue Oct 7, 2020 · 1 comment
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature. hosted Issues affecting Hosted Weblate service.
Milestone
4.3

Comments

@nijel
Copy link
Member

nijel commented Oct 7, 2020

Is your feature request related to a problem? Please describe.
When the string is propagated to many components, its update takes ages or does never complete.

Describe the solution you'd like
The update should be reasonably fast. It will be still slow operation to perform, but it should complete.

Describe alternatives you've considered
There might be completely different approach to propagation needed, see #3166

Additional context
Observed on https://translate.fedoraproject.org/translate/fedora-docs-l10n-fedora-system-administrat/f27pageswayland/pl/?checksum=ba023179ac8f3eb1#translations

My guess is that the checks update need a lot of time, especially propagated - these should be batched somehow as right now it probably triggers 39601 (199 x 199) times...
@nijel nijel added enhancement Adding or requesting a new feature. hosted Issues affecting Hosted Weblate service. labels Oct 7, 2020
@nijel nijel added this to the 4.3 milestone Oct 7, 2020
@nijel nijel self-assigned this Oct 13, 2020
nijel added a commit that referenced this issue Oct 13, 2020
@nijel
Unit: Indicate desired action in save params
d82d1a4 
This is easier to understand than same_state param.

Issue #4661
@nijel nijel closed this as completed in 1bd0f1b Oct 13, 2020
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

nijel added a commit that referenced this issue Nov 5, 2020
@nijel
Unit: Improve checks propagation, take two
a2e54ee 
The original approach was wrong as it did cut the recursion only in one
specific case, while it is problematic in others as well. Whenever
checks are executed, there was possibility that this would recurse for
every unit leading up to N*N invocations instead of just N. The impact
was depending on (random) database ordering, so it was not always
visible.

See #4661
Fixes WEBLATE-56E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature. hosted Issues affecting Hosted Weblate service.
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
1 participant
@nijel