-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colouring of string statuses #4985
Comments
I'm not sure it's a good idea to switch colours when people are get used to them. Another important thing is that the progress bar shrinks multidimensional metric into one dimension. The strings with failing check can be any of read only/approved/needing edit/not translated, the same applies to suggestions (which are currently not represented in the progress bar). |
Therein lies the crux. Are people used to them? I haven't understood most of them yet, but mileage may vary. The option is to go for something other than teal for "read-only", and a slightly different green for "confirmed". 4. Seems to be uncontroversial? |
Thank you for your report; the issue you have reported has just been fixed.
|
@nijel Bar colours changed, and I didn't notice. Nor did I remember what the old ones were, so that seems good. https://hosted.weblate.org/projects/kinovea/root/nb_NO/ More-so than the missing indentation, What is it, and why is it gray? |
Fixed in 3bcf4b6 |
The colouring change was necessary to have consistent colour in the navigation and progress bar. Also, it now indicates whether there is something to be done on the string. The additional colours were problematic - people didn't understand them (and they were not well-defined). As for the indentation, it might be added later, but I don't see it as a priority now, and it is out of topic here. |
The lighter teal (confirmed string) colour doesn't follow from green (translated).
1. It makes sense to me that the confirmed good string should be a darker colour of good/unproblematic.
However, write-protected is currently dark green. I thought it was just confirmed strings were in the wrong place, so
This is the colour for confirmed strings, but it is the same colour as translated ones.
2. The icon for confirmed good should be the same darker green as in 1.
3. Write-protected should have the teal colour.
Similarly, I think "marked for edit" should also be a darker red than just "untranslated", and that it should be possible to distinguish fuzzied strings from those, but that is a bit further along.
Untranslated strings are transparent/gray in the main bar, which makes sense, but then red
in the categories…I think it should be the same gray/transparent everywhere, so
4. Untranslated category should have the transparent/gray colour from the main bar section.
Right now, "All strings" is gray/transparent. I think it makes sense if
5. "All strings" category should have no colour at all (?).
should be
In the main bar, the yellow field preceedes the red one, whereas in the category, red comes first.
6. Make the yellow category come before red in the main bar, or change the order in the categories?
It makes sense that "marked for edit" is more towards the "untranslated" side of the main bar, so I am thinking ordering the categories differently is better.
With that in mind.
7. Put the "all strings" category at the bottom. This way they all sum up (from top to bottom) to what is the final tally.
The "confirmed" strings are above translated ones in the categories, but then the various types of red strings are all below the red category, like "all strings" is above everything.
8. Does it make sense to move the confirmed strings to the right of translated strings on the main bar to have ultimate consistency, or like 6/7 to change the categories instead?
I sort of like how it is two passes of left to right, and that confirmed doesn't push against the translated bar.
I got a bit confused by the seemingly shared categories being a double-indentation that doesn't hold true for the above.
The text was updated successfully, but these errors were encountered: