Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checks listings #5177

Closed
comradekingu opened this issue Jan 10, 2021 · 4 comments
Closed

Improve checks listings #5177

comradekingu opened this issue Jan 10, 2021 · 4 comments
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. ux Issues related to user experience.
Milestone
4.5

Comments

@comradekingu
Copy link
Contributor

In for example https://hosted.weblate.org/checks/c_format/venom/translations/?lang=nb_NO I dismissed this check.
It still shows up there without any indication that it is dismissed, it isn't in https://hosted.weblate.org/projects/venom/translations/nb_NO/#history and it isn't in any of the categories in https://hosted.weblate.org/projects/venom/translations/nb_NO/

I think a "dismissed" category showing in all places would be in order. Don't know if it should be for each check.
@comradekingu comradekingu changed the title Dismissed checks show up as failing ones Dismissed checks show up as failing ones, or not at all Jan 10, 2021
@nijel
Copy link
Member

nijel commented Jan 10, 2021

It shows counts, and it is only in the dismissed column. The dismissed checks are useful to know as well - for example to identify problematic strings (for example in this case it indicates issue in string extraction as it's falsely marked as c-format).

@nijel nijel added enhancement Adding or requesting a new feature. ux Issues related to user experience. labels Jan 13, 2021
@nijel
Copy link
Member

nijel commented Jan 13, 2021

What might be useful here is to reorder columns to show the most important ones (translated, active) first...

@nijel nijel added this to the 4.5 milestone Jan 13, 2021
@nijel nijel added good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. labels Jan 13, 2021
@nijel nijel changed the title Dismissed checks show up as failing ones, or not at all Improve checks listings Jan 18, 2021
nijel added a commit to nijel/weblate that referenced this issue Jan 28, 2021
@nijel
Stats: Reduce amount of database queries
95f0557 
Let the database server do the join instead of doing it on Python side.

This should perform much better in most situations (it now executes
single huge query instead of seven complex queries used before).

Issue WeblateOrg#5177
nijel added a commit that referenced this issue Jan 28, 2021
@nijel
Stats: Reduce amount of database queries
59ab84d 
Let the database server do the join instead of doing it on Python side.

This should perform much better in most situations (it now executes
single huge query instead of seven complex queries used before).

Issue #5177
@nijel nijel self-assigned this Feb 5, 2021
@nijel
Copy link
Member

nijel commented Feb 5, 2021

Implemented in 3689728

@nijel nijel closed this as completed Feb 5, 2021
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. ux Issues related to user experience.
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
2 participants
@nijel @comradekingu