Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several issues with new glossary implementation #5486

Closed
7 tasks done
Fat-Zer opened this issue Feb 21, 2021 · 6 comments
Closed
7 tasks done

Several issues with new glossary implementation #5486

Fat-Zer opened this issue Feb 21, 2021 · 6 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@Fat-Zer
Copy link
Collaborator

Fat-Zer commented Feb 21, 2021

I've noticed several relatively small issues in recent glossary reimplementation and its documentation. I don't feel like each of those deserves it's own bug report. Although I don't want them to get lost.

Describe the issues

  • Marking terms as forbidden are available for users now, but it shows an «insufficient privileges» error (despite actually adds the flag).
  • IMHO marking terms as "Not translatable" should be available for users as it should be managed by translators and the set of such words may differ from one language to another.
  • Adding explanations should be available for users and bond to translation.
  • It would be nice to have explanations available from the glossary panel (probably in form of a tooltip)/source string tooltip text.
  • Glossary documentation messages that you can share a glossary with an another project quite badly: it can be misread as "If you have a shared component, you will share the glossary"
  • It would be nice to have a shortcut to browse the glossary on the side panel e.g, an eye-shaped icon besides the pen one.
  • It would be nice to have a more clear designation for forbidden translations: may be an icon with an exclamation mark as for the configuration errors between the term and the translation.
@nijel
Copy link
Member

nijel commented Feb 21, 2021

The explanation should be already available in the glossary panel. I will check rest later...

@nijel nijel added this to the 4.5.1 milestone Feb 21, 2021
@nijel nijel self-assigned this Feb 22, 2021
@nijel nijel added the enhancement Adding or requesting a new feature. label Feb 22, 2021
nijel added a commit that referenced this issue Feb 22, 2021
It was properly saved, but later raised a permission error.

Issue #5486
@Fat-Zer
Copy link
Collaborator Author

Fat-Zer commented Feb 22, 2021

I'm felling like I'm pushing some keep-feedback-useful limit, adding more and more to the list... Feel free to tell me to stop or if you want it in some other format...

nijel added a commit that referenced this issue Feb 22, 2021
It makes sense and is consistent with others.

See #5486
nijel added a commit that referenced this issue Feb 22, 2021
nijel added a commit that referenced this issue Feb 22, 2021
It is more useful instead of edit (it was not present before).

Issue #5486
@tjhietala
Copy link
Contributor

There's also the small issue that there's nothing to indicate that the user is editing the glossary. It looks just like any other component. Even the glossary pane on the right hand side is displayed! (example)

@tjhietala
Copy link
Contributor

Correction: Actually it says "Glossary term", but that might be easily missed as evidenced above...

@nijel
Copy link
Member

nijel commented Feb 26, 2021

It is more visible since 353ff0e.

nijel added a commit that referenced this issue Mar 5, 2021
@nijel nijel modified the milestones: 4.5.1, 4.5.2 Mar 5, 2021
@nijel nijel closed this as completed in 67944c7 Mar 25, 2021
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants