Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong source language in TBX #5497

Closed
ilocit opened this issue Feb 22, 2021 · 1 comment
Closed

Wrong source language in TBX #5497

ilocit opened this issue Feb 22, 2021 · 1 comment
Assignees
@nijel
Labels
bug Something is broken.
Milestone
4.5.1

Comments

@ilocit
Copy link
Contributor

ilocit commented Feb 22, 2021

With the new, cool glossary feature in v4.5 a bug was introduced into the writing/handling of the terms in TBX.

When you add a new term, the source language of the project/component is not respected.
Looking at the TBX, you see that the new German term "Drehlagen" was added with <langSet xml:lang="en"> to the TBX!

image

This is critical!
@nijel nijel changed the title Glossary Bug! Wrong source language in TBX Wrong source language in TBX Feb 22, 2021
@nijel nijel added the bug Something is broken. label Feb 22, 2021
@nijel nijel added this to the 4.5.1 milestone Feb 22, 2021
@nijel nijel self-assigned this Feb 22, 2021
@nijel nijel closed this as completed in b2637a6 Feb 22, 2021
nijel added a commit that referenced this issue Feb 22, 2021
@nijel
Formats: Fix passing source language info
6786316 
Issue #5497
nijel added a commit that referenced this issue Feb 22, 2021
@nijel
Formats: Improve building LISA units
26d3ed2 
These are better to explicitely define a source language.

Fixes #5497
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@ilocit ilocit mentioned this issue Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
bug Something is broken.
Projects
None yet
Milestone
4.5.1
Development

No branches or pull requests
2 participants
@nijel @ilocit