Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown link checking missing <https://weblate.org> link syntax #5507

Closed
eighthave opened this issue Feb 23, 2021 · 1 comment
Closed

markdown link checking missing <https://weblate.org> link syntax #5507

eighthave opened this issue Feb 23, 2021 · 1 comment
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
4.5.1

Comments

@eighthave
Copy link
Contributor

eighthave commented Feb 23, 2021 •
edited

Describe the issue

The markdown link checking should check that the translation has the same links as the source. It is failing on links using <https://weblate.org> syntax, e.g. https://weblate.org. Recently, these strings have started getting translated as <https:></https:> across many languages. I'm guessing that is coming from either machine translation or some kind of translation merge bug.

This was merged from hosted.weblate.org:
https://gitlab.com/fdroid/fdroid-website/commit/ff43a3e0655c0df6b1bfc32088477f6d1ce4f73d

It comes from this:
https://hosted.weblate.org/projects/f-droid/website-posts/

I already tried

Manually copying the source to the translation fixes it as a workaround.
@nijel nijel self-assigned this Feb 23, 2021
@nijel nijel added the enhancement Adding or requesting a new feature. label Feb 23, 2021
@nijel nijel added this to the 4.5.1 milestone Feb 23, 2021
nijel added a commit that referenced this issue Feb 23, 2021
@nijel
Checks: Improve mardown link check
5f7b329 
Look for <> syntax as well.

This also refactors the regexp (to use verbose syntax) and tests (to use
single testcase for markdown links).

Issue #5507
@nijel nijel closed this as completed in aadedaa Feb 23, 2021
@github-actions
Copy link

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
4.5.1
Development

No branches or pull requests
2 participants
@eighthave @nijel