Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large number of glossary entries slow down the loading of strings #5545

Closed
tomkolp opened this issue Mar 1, 2021 · 4 comments
Closed

Large number of glossary entries slow down the loading of strings #5545

tomkolp opened this issue Mar 1, 2021 · 4 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@tomkolp
Copy link
Contributor

tomkolp commented Mar 1, 2021

The glossary has 70,000 entries, which means that loading strings takes over 6 seconds. Can the glossary search start after loading the string?image
When I turned off the glossaries, the time went down 1000 msecs

@nijel
Copy link
Member

nijel commented Mar 1, 2021

Right now this cannot be separated.

The match expression for glossaries is cached, so it should not take that long in the usual case. When the glossary was changed, building of the matcher might take some time, though. Do you observe this with every request or occasionally?

@tomkolp
Copy link
Contributor Author

tomkolp commented Mar 1, 2021

It happens all the time, in every component.

@nijel nijel self-assigned this Mar 1, 2021
@nijel nijel added the bug Something is broken. label Mar 1, 2021
@nijel nijel added this to the 4.5.1 milestone Mar 1, 2021
@nijel nijel closed this as completed in e52514e Mar 1, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit that referenced this issue Mar 1, 2021
This considerably reduces cache pressure on non changing glossaries.

Issue #5545
@tomkolp
Copy link
Contributor Author

tomkolp commented Mar 2, 2021

I tested it, it works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants