Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgmerge ignores base language #6127

Closed
PawelSpoon opened this issue Jun 1, 2021 · 8 comments
Closed

msgmerge ignores base language #6127

PawelSpoon opened this issue Jun 1, 2021 · 8 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@PawelSpoon
Copy link

Describe the issue

our service team did update to 4.6.2 on 22.5. now a week after team reports that strings added to pot file do not get propagated to po files. we use monolingual gettext, have base language english and set as editable. this setting was agreed upon together with you guys. until recently the installed msgmerge addon would also update the english base file

I already tried

i have added a string to a different test component, pulled, checked for updates, changed edit base file flag etc.

To Reproduce the issue

Steps to reproduce the behavior:

  1. Go to git, add a key to pot file and commit change (branch linked with weblate)
  2. In weblate ui go to component, and execute a pull
  3. go to translate and check if new strings are available: no they arent
  4. go to git and check if weblate did a commit: yes it did but only for de, not for en po file
  5. go to container and checks log (result see above)
  6. create a new translation and check: new strings are not available in webui.
  7. go and check git for new translation: it contains all the strings (old and new)

Expected behavior

also base file should be updated with new keys as in earlier versions

Screenshots

Exception traceback
celery-notify stderr | [2021-06-01 12:23:30,527: INFO/MainProcess] Received task: weblate.accounts.tasks.notify_change[ccb16d85-32c1-41ea-9605-89fc46aea213]
6/1/2021 2:23:30 PM uwsgi stderr | [2021-06-01 12:23:30,570: DEBUG/562] tfms-cus/stmd: running post_update addon: weblate.gettext.msgmerge
6/1/2021 2:23:30 PM uwsgi stderr | [2021-06-01 12:23:30,633: INFO/562] tfms-cus/stmd: weblate.gettext.msgmerge addon skipped, new base was not updated

Server configuration and status

Weblate installation: weblate.org service / Docker / PyPI / other

Weblate deploy checks

Additional context

@PawelSpoon PawelSpoon changed the title msgmerge ignores base image msgmerge ignores base language Jun 1, 2021
nijel added a commit that referenced this issue Jun 2, 2021
nijel added a commit that referenced this issue Jun 2, 2021
This is safer for doing repeated lookups.

See #6127
@nijel
Copy link
Member

nijel commented Jun 2, 2021

Weblate looks at the changes and triggers msgmerge only in case the pot file was changed. It seems like it didn't work as expected here.

From which version did you upgrade? Maybe this would help when searching for the regression...

@PawelSpoon
Copy link
Author

PawelSpoon commented Jun 2, 2021

Hi,
to me it seems like:

  • it gets triggered by pot file change
  • BUT it skips the base image

and until base image file is not updated weblate does not show the new key in any of the languages..

@igorjesih
Copy link

Hello,
Weblate was upgraded from version 4.2.2. (docker tag 4.2.2-3)

@nijel
Copy link
Member

nijel commented Jun 2, 2021

The log says:

weblate.gettext.msgmerge addon skipped, new base was not updated

It is not updating any files at this point...

Weblate was upgraded from version 4.2.2. (docker tag 4.2.2-3)

Ah, that's big step, that will be hard to look at the changes...

@PawelSpoon
Copy link
Author

The log says:

weblate.gettext.msgmerge addon skipped, new base was not updated

It is not updating any files at this point...

Weblate was upgraded from version 4.2.2. (docker tag 4.2.2-3)

Ah, that's big step, that will be hard to look at the changes...

yes it is not updating on purpose.
but if i interpret the commits in git correctly:

  • it does react on pot file change
  • it skips the en base language file
  • it updates the de file

@nijel
Copy link
Member

nijel commented Jun 2, 2021

Okay, in that case the log you have posted is not from the situation when the de file was updated - it is from the situation when no file was updated.

@nijel
Copy link
Member

nijel commented Jun 2, 2021

The behavior you describe might be caused by 3178f88

@nijel nijel added the bug Something is broken. label Jun 2, 2021
@nijel nijel self-assigned this Jun 2, 2021
@nijel nijel added this to the 4.7 milestone Jun 2, 2021
@nijel nijel closed this as completed in c9daa14 Jun 2, 2021
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

3 participants