Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth provider title and image override do not work for auth providers with '-' in it #6216

Closed
1 task done
derkoe opened this issue Jun 22, 2021 · 1 comment · Fixed by #6217
Closed
1 task done
Assignees
Labels
bug Something is broken.
Milestone

Comments

@derkoe
Copy link
Contributor

derkoe commented Jun 22, 2021

Describe the issue

The new feature to override the name and image for an auth provider (introduced in 159ae59) does not work for auth providers with '-' in them.

I already tried

Describe the steps you tried to solve the problem yourself.

  • I've read and searched the docs and did not find the answer there.
    If you didn’t try already, try to search there what you wrote above.

To Reproduce the issue

Steps to reproduce the behavior:

  1. Add an auth to your settings - e.g. SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_KEY
  2. Set the title and image override (SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_TITLE and SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_IMAGE)
  3. Go to the login page
  4. The title and image are not overriden

Expected behavior

The title and image should be overridden.

@nijel nijel added this to the 4.7.1 milestone Jun 22, 2021
@nijel nijel added the bug Something is broken. label Jun 22, 2021
nijel pushed a commit that referenced this issue Jun 22, 2021
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants