hoste.weblate.org - links get mangled

[licaon-kter]

Steps to reproduce the behavior:

1. Go to https://hosted.weblate.org/translate/f-droid/website-posts/ro/?checksum=3155de3b1a1a0cde&sort_by=-priority,position#nearby
2. Fix the end link with the proper one from source string
3. Click on approve or for review
4. Save
5. See translated string as ...Weblate F-Droid (<https:>).</https:>

Expected behavior

Translated string should be ...Weblate F-Droid (<https://hosted.weblate.org/languages/ro/f-droid/>).

[eighthave]

We've been getting a lot of these on the Markdown/gettext sections of f-droid.org (f-droid/weblate-page, f-droid/weblate-posts, f-droid/weblate-docs). I have a utility script to catch them when I merge. The existing Weblate link checkers do mark these cases.

[nijel]

In this case, it is caused by safe-html flag - it treats the content as HTML, and performs cleanup on the string:

Using safe-html flag on non-HTML content can cause such issues.

[github-actions]

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

[licaon-kter]

@nijel where is that controlled?

[eighthave]

I can handle it.

[eighthave]

Upon thinking about this, I guess the hard part here is that just about all HTML would be valid in Markdown, so _safe-html_ is quite useful for Markdown text. But then that does make it harder to write the _safe-html_ plugin. Here's the official docs on using HTML in Markdown: https://daringfireball.net/projects/markdown/syntax#html

[github-actions]

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

[eighthave]

I wonder if the safe_html plugin could be made to ignore the Markdown links. It seems like a pretty safe pattern: r'<https?://[^>]+>'

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

[eighthave]

Amazing, thanks!