Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary term explanation cannot be added or edited #6283

Closed
2 tasks done
luebbe opened this issue Jul 13, 2021 · 4 comments
Closed
2 tasks done

Glossary term explanation cannot be added or edited #6283

luebbe opened this issue Jul 13, 2021 · 4 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@luebbe
Copy link
Contributor

luebbe commented Jul 13, 2021

Describe the issue

I added an abbreviation as glossary term to the source language (English) and tried to add an explanation.

grafik

Things I have observed:

  1. You can enter a text "this is an explanation" into the "explanation" field, but the save button stays disabled
  2. You can enter an explanation "this is another explanation" via the "explanation edit" dialog. The value you enter there overwrites the value you have previously entered into the "explanation" field, but the save button still stays disabled. The new explanation is visible twice.
  3. Removing the write protection via the drop-down menu has no effect.

The first screenshot shows the state after steps 1..2, the second one tries to further illustrate my observations.
If you "remove write protection" via the drop down, already entered explanations are lost.
Moving forward or back with the navigation buttons obviously loses the explanation

grafik

I would have expected the save button to be active or at least to become active after "remove write protection" was selected
I would have expected all edit functions to be disabled (edit fields, "pen" buttons",...) when the entry is write protected. When I can't edit or save an entry it should be clear from the start. Why should I waste my time entering information that can't be saved.

I already tried

Describe the steps you tried to solve the problem yourself.

  • I've read and searched the docs and did not find the answer there.
    If you didn’t try already, try to search there what you wrote above.
  • I've searched the issue tracker and found no similar issue

Server configuration and status

Weblate 4.7.1 on docker

@nijel
Copy link
Member

nijel commented Jul 21, 2021

What are your component settings for "Manage strings" / "Monolingual base language file" / "Edit base file" on the glossary?

@luebbe
Copy link
Contributor Author

luebbe commented Jul 21, 2021

Since I haven't touched anything in the glossary settings knowingly, I'd say "the weblate defaults". This is what I see in the glossary's Settings->Files:

grafik

@github-actions
Copy link

github-actions bot commented Aug 1, 2021

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added the wontfix Nobody will work on this. label Aug 1, 2021
@nijel nijel added bug Something is broken. and removed wontfix Nobody will work on this. labels Aug 3, 2021
@nijel nijel self-assigned this Aug 3, 2021
@nijel nijel added this to the 4.8 milestone Aug 3, 2021
nijel added a commit that referenced this issue Aug 3, 2021
This is confusing when it can be edited but not saved.

Issue #6283
@nijel nijel closed this as completed in 102e63f Aug 3, 2021
@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit that referenced this issue Feb 27, 2023
When user can edit flags, but can not save translations, the Save button
is needed only for glossaries, otherwise the form would do nothing.

Followup to #6283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants