Bulk handling for suggestions

[paulpach]

A person came to my site and added hundreds of suggestions.

Currently I have to review each suggestion one at a time, and accept them one at a time.

It would be great if there was a "zen mode" for reviewing large number of suggestions.

[Frexuz]

Would like to see this too! We added 7 languages, each with about 800 strings to translate. I've spend hours accepting :P

[derikson]

This looks to me like a duplicate of #849.

[mark-yougov]

It would be great if there was a "zen mode" for not only reviewing a large number of suggestions but also bulk approving all the suggestions in the language. ie having an "Approve All Suggestions" button.

[exzhawk]

My implementation exzhawk@ce51069
The commit id may be changed due to rebase, look up recent log for corresponding commit https://github.com/exzhawk/weblate/commits/epix_mod
Known issue: No vote/spam function.
Screenshot

[comradekingu]

@exzhawk Avatars is a great idea.
I think it would be better to put them left-aligned (with a mouseover for the name) so that the text has a clear A-B comparison top to bottom, instead of being offset.
Better for long strings.

To solve the issue of all fields then looking the same, I think a suggestion colour would set it apart from the other fields.
Not a big issue though. Suggestions are somewhat rare.
(That doesn't mean people won't start using them now that they will be valuable.)

The copy, and clone buttons might be more useful than clicking(?) to edit, and then clicking the checkmark?
It isn't obvious where clicking the pencil starts editing the string. Is it the suggestion field, or the regular field?

[nijel]

Workaround in Python: #8554 (comment)

[juliancoffee]

Is it something that is accepted as a feature? If it just needs an actual implementation, I could try to create a PR.

[nijel]

@juliancoffee Yes, it is accepted that we need such a feature. The exact design was not yet discussed, so please post your proposal here before implementing so that feedback can be provided.

[juliancoffee]

Well, I quite like the design in #671 (comment).

It seems to include both a "Suggest" button with an exclamation sign, as well as all suggestions with accept/accept and edit/trash buttons. And looks quite clean. Except, I don't think we need to have suggestions to be different colours or smth, having an avatar and all the buttons gives IMO enough information to differentiate between current translation and suggestions.

And maybe add a vote button along with accept/accept and edit/trash. (which also can be pushed slightly up, to avoid hiding the message behind)

[nijel]

Yes, that makes sense. I think the main question is whether to make it available in the zen mode, or it would be a separate view for dealing with the suggestions. I can see benefits in both approaches. Having it included makes the suggestions available while translating. Having it separate can make the UI more streamlined for suggestions removing not needed parts.

[juliancoffee]

Having it separate can make the UI more streamlined for suggestions removing not needed parts.

I think we can just dispatch on whether the user has translation rights?

[nijel]

User having permission to accept suggestions will often have also permission to edit the translation, so that is IMHO not the way to decide this.

[juliancoffee]

Yeah, I think having them separate might be both simpler to implement (or not) and simpler to use. But we can adjust it afterwards.
(also I finally started working on it)

[juliancoffee]

here's a start #11187, I actually went via always showing suggestions and translations at the same time