Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple-T gradle-play-publisher app store metadata files are not detected #6716

Closed
rtsisyk opened this issue Oct 25, 2021 · 8 comments
Closed
Assignees
Labels
bug Something is broken.
Milestone

Comments

@rtsisyk
Copy link

rtsisyk commented Oct 25, 2021

Component: https://hosted.weblate.org/projects/organicmaps/google-play-metadata/
Source: https://github.com/organicmaps/organicmaps/tree/master/android/src/google/play/listings/
Settings:

image

Result:

image

@comradekingu
Copy link
Contributor

comradekingu commented Oct 25, 2021

I think it might be the dashes instead of underscores in the filenames.
short-description.txt vs short_description.txt
full-description.txt vs full_description.txt

Also, I don't abide by or pledge allegiance to your code of conduct.
It is not organic in the slightest.
If you remove it I am happy to contribute a nb_NO translation.

@rtsisyk
Copy link
Author

rtsisyk commented Oct 25, 2021

I think it might be the dashes instead of underscores in the filenames.

The current directory layout was created by Triple-T. Nobody renamed files after that.

Also, I don't abide by or pledge allegiance to your code of conduct. It is not organic in the slightest.

What is wrong with Organic Maps's code of conduct? Could you please elaborate? hello@organicmaps.app or just create a ticket in the corresponding repository to avoid off-topic here. Thanks!

@comradekingu
Copy link
Contributor

I can have a look to compare it against other projects if you add "kingu".

@nijel nijel added the bug Something is broken. label Oct 26, 2021
@nijel nijel self-assigned this Oct 26, 2021
@nijel nijel added this to the 4.9 milestone Oct 26, 2021
@nijel
Copy link
Member

nijel commented Oct 26, 2021

The parsing crashes on the graphics symlink, working on a fix....

@sentry-io
Copy link

sentry-io bot commented Oct 26, 2021

Sentry issue: WEBLATE-7QC

@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@rtsisyk
Copy link
Author

rtsisyk commented Oct 29, 2021

Sorry for that broken symlink. It was a quick and dirty solution to solve some automation problem. I am glad that it helped to fix security issue. Thanks for the fix!

@nijel
Copy link
Member

nijel commented Oct 29, 2021

I don't see a security issue in that - in the worst case, Weblate translation change tracking hash would include the file outside the repository (hashed together with other files). This hash is not exposed anywhere, it's used only internally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

3 participants