Source text in history (changes) event is always the same as the latest source text

[Geeyun-JY3]

Describe the issue

Source text in history (changes) event is always same as the latest source text. It may confused users.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

Shown in everywhere the event shown, such as History tab of any target string translate page, changes page.

Expected behavior

Show the source text at that time.

Screenshots

Example: https://hosted.weblate.org/translate/weblate/hosted-error-pages/zh_Hans/?checksum=92048f2895471655

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

[github-actions]

Thank you for your report; the issue you have reported has just been fixed.

• In case you see a problem with the fix, please comment on this issue.
• In case you see a similar problem, please open a separate issue.
• If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

[Geeyun-JY3]

@nijel Still can reproduce this bug.
Example: https://hosted.weblate.org/translate/skytube/strings/zh_Hans/?checksum=e6764355a05958c4

[nijel]

Should be fixed by 10f3c4e

[Geeyun-JY3]

@nijel It seems that this bug is still not completely fixed.
A recent example: https://hosted.weblate.org/translate/f-droid/f-droid/zh_Hans/?checksum=8ffca01dbdaf4d5a#history

[nijel]

The previous source string was not stored before 790d8dd, so it is expected for old changes to not have matching source string...

[Geeyun-JY3]

Got it. Thanks for the explanation.

[Geeyun-JY3]

@nijel Still can reproduce this bug in suggestion-related events.

Example: https://hosted.weblate.org/translate/libretube/libretube/zh_Hans/?checksum=82bebea27ebe8cd8#history
The corresponding source text of the suggestion added in 2022-06-10T12:44:48+00:00 should be There is a new update available. Click okay to become redirected to the update page on GitHub.

I guess all the suggestion-related events(Suggestion accepted, Suggestion added, Suggestion removed, Suggestion removed during cleanup) have this bug.
BTW, I think storing the previous source strings may not be enough for the fixes for Suggestion accepted events. A warning dialog may be needed.

[nijel]

That one should be fixed in 4ebf4c9