Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust DEFAULT_PULL_MESSAGE in docker compose #7204

Closed
2 tasks done
jojomatik opened this issue Feb 3, 2022 · 4 comments · Fixed by #7284
Closed
2 tasks done

Adjust DEFAULT_PULL_MESSAGE in docker compose #7204

jojomatik opened this issue Feb 3, 2022 · 4 comments · Fixed by #7284
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.

Comments

@jojomatik
Copy link
Contributor

jojomatik commented Feb 3, 2022

Describe the issue

I'd like to adjust DEFAULT_PULL_MESSAGE in my docker compose setup.

This is currently not possible and not documented in https://docs.weblate.org/en/weblate-4.10.1/admin/install/docker.html?highlight=pull%20request#docker-environment-variables.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

No response

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

Additional context

No response

@jojomatik jojomatik added the question This is more a question for the support than an issue. label Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

@nijel nijel transferred this issue from WeblateOrg/docker-compose Feb 4, 2022
@nijel nijel added enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. and removed question This is more a question for the support than an issue. labels Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@jojomatik
Copy link
Contributor Author

jojomatik commented Feb 18, 2022

I've since had some time to experiment with this. I've tried setting WEBLATE_DEFAULT_PULL_MESSAGE in my docker compose setup and the pull request message is still on its default value.

I've therefore taken a look at the code and found these parts for WEBLATE_GITHUB_USERNAME etc.:

# GitHub username and token for sending pull requests.
# Please see the documentation for more details.
GITHUB_USERNAME = os.environ.get("WEBLATE_GITHUB_USERNAME")
GITHUB_TOKEN = os.environ.get("WEBLATE_GITHUB_TOKEN")
# GitLab username and token for sending merge requests.
# Please see the documentation for more details.
GITLAB_USERNAME = os.environ.get("WEBLATE_GITLAB_USERNAME")
GITLAB_TOKEN = os.environ.get("WEBLATE_GITLAB_TOKEN")
# Pagure username and token for sending merge requests.
# Please see the documentation for more details.
PAGURE_USERNAME = os.environ.get("WEBLATE_PAGURE_USERNAME")
PAGURE_TOKEN = os.environ.get("WEBLATE_PAGURE_TOKEN")

I suppose adding WEBLATE_DEFAULT_PULL_MESSAGE would be sufficcient to implement this feature. I will try and open up a PR later, though I don't have the time to test in real world right now. I will also update the documentation.

How long do you suppose the review process will take for such a small addition? Would it be useful to build and deploy my own image to for the time being until a new release is made?

nijel pushed a commit that referenced this issue Feb 20, 2022
Allow changing `DEFAULT_PULL_MESSAGE` in a docker compose environment using the environment variable `WEBLATE_DEFAULT_PULL_MESSAGE`. Document behaviour in `docker.rst` and `config.rst`.

Closes #7204
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants