Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burmese punctuation not detected #7375

Closed
2 tasks done
alanazar opened this issue Mar 11, 2022 · 8 comments
Closed
2 tasks done

Burmese punctuation not detected #7375

alanazar opened this issue Mar 11, 2022 · 8 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@alanazar
Copy link

Describe the issue

Hello,
While contributing to this project to solve outstanding errors I realized the Burmese punctuation is not being detected properly.
I tried researching but not sure how to fix it
https://translate.jellyfin.org/checks/end_stop/jellyfin/
https://translate.jellyfin.org/checks/end_question/jellyfin/

The Burmese full stop is this:

and the question mark is this:
း။

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

No response

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Other

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel nijel self-assigned this Mar 14, 2022
@nijel nijel added the enhancement Adding or requesting a new feature. label Mar 14, 2022
@nijel nijel added this to the 4.12 milestone Mar 14, 2022
@nijel
Copy link
Member

nijel commented Mar 14, 2022

The full stop is supported in Weblate 4.11: 8e3a19f

@nijel nijel closed this as completed in e3afc3b Mar 14, 2022
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

@alanazar
Copy link
Author

alanazar commented Aug 14, 2022

Hello,

This is still not working even though Weblate has been updated to version 4.13.1
This applies for both the full-stop and the question mark.

@nijel
Copy link
Member

nijel commented Aug 15, 2022

The upgrade will not trigger running checks, in the default configuration the checks are updated once in a month. You can trigger this manually using updatechecks management command.

@alanazar
Copy link
Author

Thank you!

@alanazar
Copy link
Author

The upgrade will not trigger running checks, in the default configuration the checks are updated once in a month. You can trigger this manually using updatechecks management command.

Hello,
Can you please check these errors?
https://translate.jellyfin.org/translate/jellyfin/jellyfin-web/my/?q=check:end_stop%20OR%20dismissed_check:end_stop

It seems Weblate is still picking up these as a full-stop error
။ – signifies a full stop, or the end of a sentence;
း။ – signifies a question mark;

The problem is weblate is picking up the last 2 lines as a misplaced fullstop even though the source is a question

@nijel nijel modified the milestones: 4.12, 4.14.1 Sep 12, 2022
nijel added a commit that referenced this issue Sep 12, 2022
- write the question mark as unicode escape sequence to avoid paste
  error on composing chars
- extend test coverage
- skip comma check for question mark sentences

Fixes #7375
@nijel
Copy link
Member

nijel commented Sep 12, 2022

I've fixed these now. It turns out that copy-pasting the composed question mark didn't work correctly and caused some issues.

@alanazar
Copy link
Author

I've fixed these now. It turns out that copy-pasting the composed question mark didn't work correctly and caused some issues.

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants