Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ResourceDictionary #7481

Closed
nijel opened this issue Apr 8, 2022 · 3 comments · Fixed by #7651
Closed

Add support for ResourceDictionary #7481

nijel opened this issue Apr 8, 2022 · 3 comments · Fixed by #7651
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature. translate-toolkit Issues which need to be fixed in the translate-toolkit
Projects
File format support
Milestone
4.13

Comments

@nijel
Copy link
Member

nijel commented Apr 8, 2022

Describe the problem

ResourceDictionary format is not supported.

Describe the solution you'd like

translate/translate#4589 will implement support in translate-toolkit

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

No response
@nijel nijel added enhancement Adding or requesting a new feature. translate-toolkit Issues which need to be fixed in the translate-toolkit labels Apr 8, 2022
@nijel nijel added this to the 4.13 milestone Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

The issue you've reported needs to be addressed in the translate-toolkit. Please file the issue there, and include links to any relevant specifications about the formats (if applicable).

@nijel
Copy link
Member Author

nijel commented May 12, 2022

From translate/translate#4589 (comment):

Because the base language is C# the placeholders seems to be the same as commonly in C# ({0} or {1:tt}).

nijel added a commit that referenced this issue May 17, 2022
@nijel
formats: Added support for ResourceDictionary format
96419fd 
This currently relies on unreleased translate-toolkit and discovery
needs unreleased translation-finder.

Fixes #7481
@nijel nijel mentioned this issue May 17, 2022
Merged
5 tasks
@nijel nijel self-assigned this May 17, 2022
@nijel nijel added this to TODO in File format support via automation May 17, 2022
File format support automation moved this from TODO to Done May 17, 2022
nijel added a commit that referenced this issue May 17, 2022
@nijel
formats: Added support for ResourceDictionary format (#7651)
87d3899 
This currently relies on unreleased translate-toolkit and discovery
needs unreleased translation-finder.

Fixes #7481
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature. translate-toolkit Issues which need to be fixed in the translate-toolkit
Projects
File format support
  
Done
Milestone
4.13
Development

Successfully merging a pull request may close this issue.

formats: Added support for ResourceDictionary format WeblateOrg/weblate
1 participant
@nijel