-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination everywhere #7571
Comments
I've added it to For user view it is a bit more tricky because more tabs could get long and then paginating becomes tricky (you would have to pass different parameter to paginate each tab). |
This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate. Please try to clarify the use case or consider proposing something more generic to make it useful to more users. |
The loading time for /user/* is bad, but elsewhere the non-pagination grants extra productivity. |
Another current offender of the absence of pages is |
@endervad Please file a separate issue for that. |
Describe the problem
Many pages include lists that may get quite long. For example
/user/<name>
. If a user has a lot of contributions, the page may be so big that it takes 2 minutes to load it.Another example is the
/projects/
page.Describe the solution you'd like
Use pagination, as it is done on
/screenshots
,/user/
,/changes
.Describe alternatives you've considered
In case of
/user/<name>
, make the contributions list a separate page.Screenshots
No response
Additional context
Apparently mostly the views that are currently paginated are subclasses of
ListView
, but for/user/<name>
there are multiple models. Can we do something like this for each tab: include{% include "paginator.html" with page_obj=user_translations %}
and passuser_translations
throughget_paginator
, like it's done insearch.py
anddashboard.py
?:weblate/weblate/trans/views/search.py
Lines 216 to 224 in f0b4c81
weblate/weblate/trans/views/dashboard.py
Lines 274 to 284 in a7c7f4d
If so, I'd like to try it.
The text was updated successfully, but these errors were encountered: